Add metrics tracking for ogr API calls per namespace and service type#3026
Open
majamassarini wants to merge 1 commit intopackit:mainfrom
Open
Add metrics tracking for ogr API calls per namespace and service type#3026majamassarini wants to merge 1 commit intopackit:mainfrom
majamassarini wants to merge 1 commit intopackit:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new periodic task to track and push ogr API call metrics. The implementation is straightforward, but I have a few suggestions to improve its robustness and clarity. I've also noted that automated tests are missing for the new functionality, which is required by the repository's contributing guidelines.
Contributor
|
✔️ pre-commit SUCCESS in 1m 48s |
Contributor
|
✔️ pre-commit SUCCESS in 1m 48s |
majamassarini
force-pushed
the
count-requests-per-namespace
branch
from
e51e2b2 to
485e38f
Compare
Contributor
|
✔️ pre-commit SUCCESS in 4m 03s |
majamassarini
force-pushed
the
count-requests-per-namespace
branch
from
485e38f to
7f661aa
Compare
Contributor
|
✔️ pre-commit SUCCESS in 4m 30s |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should fix #2912.
Merge after packit/ogr#981.