Fixing tests broken by introduction of check for race condition

[jpodivin]

Recent changes related to race condition issue have broken database tests.

The test case test_copr_build_race_condition_concurrent_packages introduced f395aac was created as intentionally failing, without being marked as such. That is confusing, since it would mess up the report, but it also replaced SRPMBuildModel.create_with_new_run with a non-standard mock.

Since this mock method was not inserted by flexmock, or other mocking utility, it had effect on all tests that followed. Leading to their failure.

There was also a minor issue, in that the too_many_copr_builds fixture was not modified, when the return value of CoprBuildGroupModel.create method was changed by 7e99633.

[gemini-code-assist]

Code Review

This pull request addresses several issues in the test suite that were introduced by recent changes. The fixes include correctly marking an intentionally failing test with @pytest.mark.xfail, replacing a manual monkeypatch with a properly scoped flexmock mock to prevent state leakage between tests, and updating a fixture to match a changed method signature. These changes are well-justified and improve the overall health and stability of the test suite. I've found one minor but important typo in the test code that needs to be fixed.

[centosinfra-prod-github-app]

Build succeeded.
https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/packit-service/buildset/ddc2114d013b4cd08888d81250be9697

✔️ pre-commit SUCCESS in 1m 45s
✔️ packit-service-tests SUCCESS in 3m 24s

[centosinfra-prod-github-app]

Build succeeded.
https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/packit-service/buildset/706aab88d8ff4c539d58b49493c04430

✔️ pre-commit SUCCESS in 1m 49s
✔️ packit-service-tests SUCCESS in 3m 37s

[centosinfra-prod-github-app]

Build succeeded.
https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/packit-service/buildset/3d63f11be7f84daa9f5b98fde1e741b3

✔️ pre-commit SUCCESS in 1m 52s
✔️ packit-service-tests SUCCESS in 3m 26s

[nforro]

LGTM

[majamassarini]

Thanks, I didn't realize I broke other tests. I checked and, using flexmock, the test still triggers the race condition, so LGTM.
However, I will keep the comments since this is a complex unit test and I think they are useful.

[centosinfra-prod-github-app]

Build succeeded.
https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/packit-service/buildset/c7674b93c3744501a588ae05e3c3c371

✔️ pre-commit SUCCESS in 1m 47s
✔️ packit-service-tests SUCCESS in 3m 25s

[centosinfra-prod-github-app]

Build succeeded.
https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/packit-service/buildset/ca2e1dbb5a1a4c2e946e40e84ed1ed6e

✔️ pre-commit SUCCESS in 1m 48s
✔️ packit-service-tests SUCCESS in 3m 31s

[centosinfra-prod-github-app]

Build succeeded.
https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/packit-service/buildset/bc59069c320143218e143a9116c2ebd1

✔️ pre-commit SUCCESS in 1m 49s
✔️ packit-service-tests SUCCESS in 3m 58s

[centosinfra-prod-github-app]

Build succeeded.
https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/packit-service/buildset/9f4821a678924eeb96e313a941776ae0

✔️ pre-commit SUCCESS in 1m 44s
✔️ packit-service-tests SUCCESS in 3m 43s

[centosinfra-prod-github-app]

Build succeeded (gate pipeline).
https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/packit-service/buildset/35b74f95ab0c458f96cf3d3925b680bf

✔️ pre-commit SUCCESS in 1m 45s