Add coverage to requirements-dev.txt and enable it at pipeline#164
Open
NexSabre wants to merge 2 commits intop4lang:mainfrom
Open
Add coverage to requirements-dev.txt and enable it at pipeline#164NexSabre wants to merge 2 commits intop4lang:mainfrom
NexSabre wants to merge 2 commits intop4lang:mainfrom
Conversation
Contributor
Author
|
@saynb @slicking @antoninbas can I please you for review? |
antoninbas
reviewed
Jan 3, 2022
| .PHONY: coverage-check | ||
| coverage-check: | ||
| @echo "Checking coverage..." | ||
| python -m coverage report --fail-under=28 |
Member
There was a problem hiding this comment.
I know that 28 is the current coverage level, but as it is, it seems to be coming out of nowhere. I believe all code coverage tools have some mechanism to ensure that coverage for a PR hasn't decreased compared to the base branch. Is it possible to use this instead of setting an arbitrary target?
Contributor
Author
There was a problem hiding this comment.
We can certainly do that, but for now, it is enough to increase it from time to time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Coverage check at the pipeline, will fail under 28%.