feat(collaboration): enable EnableInsertRemoteFile and EnableInsertRemoteImage WOPI flags

[pedropintosilva]

Add EnableInsertRemoteFile flag to Collabora CheckFileInfo response,
enabling multimedia insertion and document comparison menus in Collabora
Online (UI_InsertFile postMessage, available since 24.04.10).

Also wire up EnableInsertRemoteImage which was defined but never set in
the CheckFileInfo infoMap.

Tests:

go test ./services/collaboration/...

All 134 connector tests pass locally.

Signed-off-by: Pedro Pinto Silva pedro.silva@collabora.com

---

Screenshots

---

PR's Notes

Collabora Online documentation:

• https://sdk.collaboraonline.com/docs/advanced_integration.html#enableinsertremoteimage
  • https://sdk.collaboraonline.com/docs/postmessage_api.html#ui-insertgraphic
• https://sdk.collaboraonline.com/docs/advanced_integration.html#enableinsertremotefile
  • https://sdk.collaboraonline.com/docs/postmessage_api.html#ui-insertfile

This is just the server side change we still require a frontend side (owncloud/web#13658) change to handle the UI_InsertGraphic and UI_InsertFile postMessages that Collabora sends when the user clicks the new menu items.

The existing FilePickerModal.vue (https://github.com/owncloud/web/blob/master/packages/web-pkg/src/components/Modals/FilePickerModal.vue#L68) at packages/web-pkg/src/components/Modals/FilePickerModal.vue is for "Open With App" (user picks a file and it opens that file in a new editor tab) but we need something different here, something that:

1. Accepts allowedFileTypes (e.g. ['image/png', 'image/jpeg'] for Insert Graphic, or whatever mimeTypeFilter Collabora sends for Insert File)
2. Gets the picked file's download URL
3. Send it back to the Collabora iframe via postMessage (Action_InsertGraphic, Action_InsertMultimedia, or Action_CompareDocuments)

I'm not sure if I can do it or how would you prefer it (to refactor the existing FilePickerModal or create a new one for this case)

[update-docs]

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

[mmattel]

@pedropintosilva Thanks for the PR. Please check the following to prepare approval to run the workflow:

• You must use signed commits, see:
  https://central.owncloud.org/t/upcoming-changes-for-developers-what-you-need-to-know/65650
• You must add a changelog
  For a template see the changelog/unreleased folder

[jvillafanez]

Code looks fine, although I'm not sure if we want to have the feature enabled at the moment. As you've said, we need changes in the frontend to make it work, otherwise the feature would look like broken (unless they provide something by default).

For the frontend changes, it's better to check with the frontend devs (https://github.com/owncloud/web), so you can open a ticket there.
I think there were some other buttons in collabora with similar "problems", in case you want to include them in your plans.

[jvillafanez]

Also wire up EnableInsertRemoteImage which was defined but never set in the CheckFileInfo infoMap.

To clarify a bit, since we needed changes in the frontend to make it work, I decided not to include it (so it was set to false by default). It was intentional.

[pedropintosilva]

@pedropintosilva Thanks for the PR. Please check the following to prepare approval to run the workflow:

• You must use signed commits, see:
  https://central.owncloud.org/t/upcoming-changes-for-developers-what-you-need-to-know/65650
• You must add a changelog
  For a template see the changelog/unreleased folder

thanks I have forced pushed, now signed and with the extra markdown file.

[mmattel]

@jvillafanez shall we approve the workflow run to see if any coding issues pop up?

[pedropintosilva]

Code looks fine, although I'm not sure if we want to have the feature enabled at the moment. As you've said, we need changes in the frontend to make it work, otherwise the feature would look like broken (unless they provide something by default).

For the frontend changes, it's better to check with the frontend devs (https://github.com/owncloud/web), so you can open a ticket there. I think there were some other buttons in collabora with similar "problems", in case you want to include them in your plans.

Thanks, I have created another PR against that repo. I hope it helps.

[jvillafanez]

@pedropintosilva please rebase / update your branch to the latest master code.
It seems the pipeline had a problem because the go-git library version isn't the latest. Current master code already have the library updated, so you just need to apply your changes on top of it. There shouldn't be any new changes shown here.

[pedropintosilva]

rebased; touch ocis/cmd/ocis/main.go && make -C ocis build successfully and tested manually.

[pedropintosilva]

I think the workflow needs approval.