Enable ssl for scale test which includes:#154
Open
noah8713 wants to merge 1 commit intoovn-org:masterfrom
Open
Enable ssl for scale test which includes:#154noah8713 wants to merge 1 commit intoovn-org:masterfrom
noah8713 wants to merge 1 commit intoovn-org:masterfrom
Conversation
noah8713
force-pushed
the
ovn_ssl
branch
2 times, most recently
from
7910079 to
78c9767
Compare
1. HVs ovn-controller talk to southbound db via ssl on port 6642 2. Starting and setting of southbound and northbound dbs with pssl on ports 6642 and 6641 respectively. 3. Set inactivity_probe=0 on southbound db to avoid HVs ovn-controller throwing ssl connection errors and exiting the cluster.
hzhou8
requested changes
Mar 26, 2018
| conf-sb.db ovnsb.db | ||
| pid=`cat $sandbox_name/$prog_name.pid` | ||
| mv $sandbox_name/$prog_name.ctl $sandbox_name/$prog_name.$pid.ctl | ||
| fi |
Collaborator
There was a problem hiding this comment.
Could you abstract the different part only, instead of a big if-else block?
| abs_path=`pwd`/certs | ||
| ovn-nbctl set-ssl $abs_path/ovnnb-privkey.pem $abs_path/ovnnb-cert.pem \ | ||
| $abs_path/cacert.pem | ||
| ovn-nbctl set-connection pssl:6641:127.0.0.1 |
Collaborator
There was a problem hiding this comment.
why 127.0.0.1? Rally may need to access NB remotely.
Contributor
Author
There was a problem hiding this comment.
So by default it will be localhost where we are setting up controller sandbox. We are not using cluster here. Hence when we run all the nbctl commands too , we source sandbox rc and do it. Once we introduce to spin up clustered db, we can leverage the actual IPs. Not needed now.
| # Initialize database. | ||
| if $controller ; then | ||
| init_ovsdb_server "ovsdb-server-nb" $OVN_NB_DB | ||
| init_ovsdb_server "ovsdb-server-sb" $OVN_SB_DB |
Collaborator
There was a problem hiding this comment.
Why init_ovsdb_server is not needed?
| cmd = "./ovs-sandbox.sh --ovn --controller-ip %s \ | ||
| --host-ip %s/%d --device %s" % \ | ||
| (controller_ip, host_ip, sandbox_cidr.prefixlen, | ||
| net_dev) |
Collaborator
There was a problem hiding this comment.
please abstract out the different part only (--ssl)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
6642 and 6641 respectively.