Skip to content

Fix brands with clothes=outdoor - #12481

Open
StefanAvra wants to merge 8 commits into
osmlab:mainfrom
StefanAvra:main
Open

Fix brands with clothes=outdoor#12481
StefanAvra wants to merge 8 commits into
osmlab:mainfrom
StefanAvra:main

Conversation

@StefanAvra

Copy link
Copy Markdown

Hi,
I found a few shops that have the tag clothes=outdoor. According to the Wiki this is discouraged. It should either be shop=outdoor or shop=clothes + clothes=sports. According to taginfo clothes=outdoor is also not widely used (974 total, no major app uses it).
So I checked clothes.json for occurrences and fixed the following brands/shops depending on what they mostly sell in their stores. This is quiet subjective so let me know if you think something should be changed.

In 2021 there was PR #5408 that discussed The North Face and why it should not be in shop=outdoor, biggest argument being that they sell mainly clothes in their stores. The changes I made rely mostly on the arguments in that discussion. IMO brands like Patagonia could also be shop=outdoor + clothes=sports instead, but I went with the decisions made in that PR.
Later, PR #5671 added the clothes=outdoor tag to more brands.

The North Face
Changed to clothes=sports. They sell outdoor clothes, tents, bags but mostly clothes.
(potential shop=outdoor + clothes=sports)

Patagonia
Changed to clothes=sports. They sell outdoor clothes, tents, bags, climbing and fishing gear but mostly clothes.
(potential shop=outdoor + clothes=sports)

Salomon
Changed to clothes=sports. They sell mostly sports clothes and shoes, some hiking shoes and smaller backpacks but no tents or other gear.

Columbia
Changed to clothes=sports. They sell mostly sports clothes but also a bit of hiking and camping gear, like tents, hammocks, sleeping bags, sporks.

Discovery Expedition
Changed to clothes=fashion. Outdoor-lifestyle brand that sells fashionable clothes. No equipment.

Canada Goose
Dropped subtag clothes. They sell luxury cold-weather parkas mostly.

There is one remaining clothes=outdoor:
Atmosphere
The brand has been folded into the parent company Sport Chek, see https://www.atmosphere.ca/en.html
I have not changed this entry since I'm not sure what to do about this. How does deprecating brands work? Should be a separate, follow-up item.

@StefanAvra

Copy link
Copy Markdown
Author

Changes in files other than clothes.json was just reordering by the build script, btw.

@peternewman

peternewman commented Aug 1, 2026

Copy link
Copy Markdown
Collaborator

As per #5671 should we also add matchTags to the rest of these for any that are mis-tagged as shop=outdoors?

Also whilst I lost out in 2021, we do seem to be going more against the wiki now (I don't know what it said then):
https://wiki.openstreetmap.org/wiki/Key:clothes
"Do not use this. If the shop sells clothes for outdoor sports activities, use clothes=sports instead. If it also sells equipment for trekking, climbing, camping etc., use shop=outdoor instead."

"Specialized in selling sportive clothes (e.g. jerseys, swimsuits). If the shop also sells sports equipment (e.g. balls, skis, scubas), use shop=sports instead."

https://wiki.openstreetmap.org/wiki/Tag:shop%3Dsports
If the shop only sells clothes, then shop=clothes + clothes=sports is more appropriate.

https://wiki.openstreetmap.org/wiki/Tag:shop%3Doutdoor
shop=clothes + clothes=sports – shop selling outdoor sports clothing but not clothing for outdoor recreation in general.

Comment thread data/brands/shop/clothes.json
@StefanAvra

Copy link
Copy Markdown
Author

As per #5671 should we also add matchTags to the rest of these for any that are mis-tagged as shop=outdoors?

Sure, but if my Overpass query is right, there seems to be only two remaining shop=outdoor nodes in OSM. The North Face and Columbia in Japan, added over 6 years ago. I'll update these manually.
If I understand matchTags correctly, the matchTags wouldn't do anything for future tagging, right? I'm assuming that no new entries will appear because of the brand suggestion in the first place.

Also whilst I lost out in 2021, we do seem to be going more against the wiki now (I don't know what it said then): https://wiki.openstreetmap.org/wiki/Key:clothes "Do not use this. If the shop sells clothes for outdoor sports activities, use clothes=sports instead. If it also sells equipment for trekking, climbing, camping etc., use shop=outdoor instead."

"Specialized in selling sportive clothes (e.g. jerseys, swimsuits). If the shop also sells sports equipment (e.g. balls, skis, scubas), use shop=sports instead."

https://wiki.openstreetmap.org/wiki/Tag:shop%3Dsports If the shop only sells clothes, then shop=clothes + clothes=sports is more appropriate.

https://wiki.openstreetmap.org/wiki/Tag:shop%3Doutdoor shop=clothes + clothes=sports – shop selling outdoor sports clothing but not clothing for outdoor recreation in general.

I read all of this but I'm not sure if it changes any of the tags. Feel free to suggest an alternative though.

@peternewman

Copy link
Copy Markdown
Collaborator

As per #5671 should we also add matchTags to the rest of these for any that are mis-tagged as shop=outdoors?

Sure, but if my Overpass query is right, there seems to be only two remaining shop=outdoor nodes in OSM. The North Face and Columbia in Japan, added over 6 years ago. I'll update these manually. If I understand matchTags correctly, the matchTags wouldn't do anything for future tagging, right? I'm assuming that no new entries will appear because of the brand suggestion in the first place.

Hopefully there won't be many/any, but matchTags ensures that any that did appear would be captured and unified more easily.

I read all of this but I'm not sure if it changes any of the tags. Feel free to suggest an alternative though.

The North Face
Changed to clothes=sports. They sell outdoor clothes, tents, bags but mostly clothes.
(potential shop=outdoor + clothes=sports)

My reading of those wiki articles is that we should only use shop=clothes if they only sell clothes, if they sell other stuff too, they should be shop=outdoors or whatever. Which is what I was arguing for in 2021, but it seems the wiki has been made a bit more clear-cut since then.

@andrewharvey

Copy link
Copy Markdown
Collaborator

My reading of those wiki articles is that we should only use shop=clothes if they only sell clothes, if they sell other stuff too, they should be shop=outdoors or whatever. Which is what I was arguing for in 2021, but it seems the wiki has been made a bit more clear-cut since then.

I'd go with shop=clothes if it's primarily clothes, rather than a strict only clothes. If it sells both clothes and gear with equal focus then shop=outdoor, but if its mostly outdoor clothesbut they also sell some drink bottles on the side, I'd still go withshop=clothes`.

@StefanAvra

Copy link
Copy Markdown
Author

Hi Andrew, thanks for looking into this. And yes Peter, this really is the same threshold you raised in 2021.

The PR's goal is removing the discouraged clothes=outdoor tag. I'm fine with both options, whether the brands land on shop=clothes + clothes=sports or on shop=outdoor.

If we keep them as shop=clothes, we go against the Wiki Tag:shop=outdoor page, since Patagonia and The North Face sell mostly clothing for outdoor recreation.

shop=clothes + clothes=sports – shop selling outdoor sports clothing but not clothing for outdoor recreation in general.

In that case I would take care of noting this on the Talk page and describing the inconsistency.

BTW, regarding the matchTags: shop/clothes, shop/outdoor and shop/sports are already in the same outdoor matchGroup (config/matchGroups.json). Mis-tagged shop=outdoor instances are already captured. No matchTags needed.

@StefanAvra

Copy link
Copy Markdown
Author

@peternewman I moved Patagonia and The North Face to shop/outdoor since they sell outdoor gear, which aligns more with the wiki for these brands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants