Skip to content

Hong Kong / Macao petrol station recommended tags - #12184

Draft
Vectorial1024 wants to merge 32 commits into
osmlab:mainfrom
Vectorial1024:hk_fuel_review
Draft

Hong Kong / Macao petrol station recommended tags#12184
Vectorial1024 wants to merge 32 commits into
osmlab:mainfrom
Vectorial1024:hk_fuel_review

Conversation

@Vectorial1024

@Vectorial1024 Vectorial1024 commented May 10, 2026

Copy link
Copy Markdown
Contributor

This PR proposes recommended tags for the existing 5 petrol providers in Hong Kong, with the following focus:

  • Localized names
  • Keep same Wikidata IDs for international cross-referencing

Per popular demand, this PR also proposes recommended tags for the existing 5 petrol providers in Macao, with the same focus as Hong Kong.


For now, this PR is a draft, to community-review the exact tags to be recommended into the NSI. Still, I am mostly confident the proposed tag-values are correct.

When the community-review is complete, this PR will be changed from a draft PR to a pending PR.

@Kovoschiz

Copy link
Copy Markdown
Contributor

Esso use English only in HK. That's the company eg official_name:zh=
Shell does show "蜆殼", but again it seems to be referring to the company, ie "蜆殼香港及澳門油站" means Shell company's HK and Macau fueling stations. All others use eng "Shell" too.
Can be heard in TV ads, at least for Esso. I don't remember Shell in 21st century, but older videos speak of that.
Besides, almost no one uses those names in Cantonese. Different from Caltex.

@Vectorial1024

Copy link
Copy Markdown
Contributor Author

The localized names have been updated; please see if I got it right.

Re Shell, the way they describe/structure the webpages, I think there is technically a "Hong Kong and Macau Shell" subsidiary company that operates the Shell fuel stations in Hong Kong, but that feels like an implementation detail that we do not need to know. It's still the same Shell as the international company.

Comment thread data/brands/amenity/fuel.json Outdated
Comment thread data/brands/amenity/fuel.json
@Vectorial1024

Copy link
Copy Markdown
Contributor Author

TIL Wikidata supports localized webpages. This seems like a good opportunity to also update the webpage data at Wikidata. We will wait a bit here.

@Vectorial1024

Copy link
Copy Markdown
Contributor Author

The tags are ready; changing to pending PR.

@Vectorial1024
Vectorial1024 marked this pull request as ready for review May 14, 2026 07:09
@Vectorial1024

Copy link
Copy Markdown
Contributor Author

Merge conflicts resolved; ready for merging.

@Vectorial1024

Copy link
Copy Markdown
Contributor Author

Merge conflicts resolved; ready for merging.

@tommylung

Copy link
Copy Markdown
Collaborator

Caltex, Esso, and Shell can share the same tags as Macao. I think the tags can include mo.

@Vectorial1024

Copy link
Copy Markdown
Contributor Author

Noted; though for some reason this PR is not getting merged and now there are new merge conflicts.

@Vectorial1024
Vectorial1024 marked this pull request as draft July 18, 2026 07:55
@Vectorial1024 Vectorial1024 changed the title Hong Kong petrol station recommended tags Hong Kong / Macao petrol station recommended tags Jul 18, 2026
@Kovoschiz

Copy link
Copy Markdown
Contributor

@tommylung Is there no problem with Portuguese?

@Vectorial1024

Copy link
Copy Markdown
Contributor Author

Apparently, we can't have multiple presets with the same name even when they are supposed to be geopolitically mutex. @Kovoschiz What do?

@Kovoschiz

Copy link
Copy Markdown
Contributor

Sorry, what's the problem now? Why is it not allowed?

@Vectorial1024

Copy link
Copy Markdown
Contributor Author

I'm here to tell you that CI/CD says "no":

https://github.com/osmlab/name-suggestion-index/actions/runs/29649758038/job/88093952951?pr=12184

build | build:json | Error - duplicate displayName '加德士 Caltex' in:
build | build:json | ./data/brands/amenity/fuel.json

I can see the following:

  • keep separate presets, but this is clumsy (e.g. by forcibly making distinct preset names, like "Caltex (Hong Kong)")
  • combine the presets, but en and pt are not mutually shared

Comment thread data/brands/amenity/fuel.json Outdated
Comment thread data/brands/amenity/fuel.json Outdated
@Vectorial1024

Copy link
Copy Markdown
Contributor Author

We will just have different names then.

Vectorial1024 and others added 2 commits July 26, 2026 21:35
Co-authored-by: Tommylung <tommylung@users.noreply.github.com>
@Vectorial1024

Copy link
Copy Markdown
Contributor Author

@Kovoschiz the CI/CD now passes.

@tommylung are the current Macao tagging OK? If yes then will convert back to PR and continue merging.

@bhousel

bhousel commented Jul 27, 2026

Copy link
Copy Markdown
Member

Can someone summarize what this PR is about?

The first thing I see when I review it is two "Caltex" gas stations that seem like - the same thing?
But one has "name:en": "Caltex" and the other has "name:pt": "Caltex".

Surely this must be a mistake?
My gut reaction would be to just reject the PR, but there's like 20 comments here and it feels like some work was put into this..

Screenshot 2026-07-27 at 1 28 08 PM

@Kovoschiz

Kovoschiz commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

In name= and name:*= , Macau nominally use Portugese, not English. So I asked whether having only name:en= is correct there, as a question, no opinion or judgement.
If there's no "Portuguese" proper, it may even need to be name=加德士 + brand=加德士 + name:en=Caltext + brand:en=Caltex only, by a literal or strict interpretation of the guidelines on bilingualism with Cantonese and Portugese. There's not much community or activity in Macau, so it's difficult to discuss and know.

@Vectorial1024

Copy link
Copy Markdown
Contributor Author

Though, in recent years, it seems Macao is more accepting of English names. name:en might be acceptable in Macao even when strictly-speaking it's not canonical.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants