Skip to content

Root overlattice no new roots#6130

Open
bpiroddi wants to merge 14 commits into
oscar-system:masterfrom
bpiroddi:dev_lattice
Open

Root overlattice no new roots#6130
bpiroddi wants to merge 14 commits into
oscar-system:masterfrom
bpiroddi:dev_lattice

Conversation

@bpiroddi

Copy link
Copy Markdown
Contributor

No description provided.

@simonbrandhorst simonbrandhorst changed the title Dev lattice Root overlattice no new roots Jul 15, 2026
@simonbrandhorst
simonbrandhorst self-requested a review July 15, 2026 14:41
Comment thread src/NumberTheory/OverLat.jl
@simonbrandhorst

Copy link
Copy Markdown
Collaborator

Would you please add a few test (1-2 secs runtime at most).

@simonbrandhorst

Copy link
Copy Markdown
Collaborator
julia> L = direct_sum(root_lattice(:A,8),root_lattice(:D,16))[1];

julia> Oscar.overlattices_no_new_roots(L)
ERROR: AssertionError: is_elementary(Kp, p)
Stacktrace:
 [1] _isotropic_lines_representatives(p::ZZRingElem, Kp::TorQuadModule, Gp::AutomorphismGroup{TorQuadModule})
   @ Oscar ~/.julia/dev/Oscar/src/NumberTheory/OverLat.jl:76

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants