Skip to content

Add gnome regression test cases to SLE16.1 and above#25217

Closed
GraceWang571 wants to merge 1 commit intoos-autoinst:masterfrom
GraceWang571:sle161-gnome
Closed

Add gnome regression test cases to SLE16.1 and above#25217
GraceWang571 wants to merge 1 commit intoos-autoinst:masterfrom
GraceWang571:sle161-gnome

Conversation

@GraceWang571
Copy link
Copy Markdown
Contributor

Add wayland-desktopapps-gnome test suite to SLE16.1

https://openqa.suse.de/tests/21705375#details

@GraceWang571 GraceWang571 requested a review from rfan1 April 7, 2026 06:38
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 7, 2026

Great PR! Please pay attention to the following items before merging:

Files matching lib/**.pm:

  • Consider adding or extending unit tests in t/

This is an automatically generated QA checklist based on modified files.

Comment on lines +2065 to +2066
if (is_sle('<16') || is_tumbleweed) {
loadtest "x11/gnomecase/gnome_default_applications";
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (is_sle('<16') || is_tumbleweed) {
loadtest "x11/gnomecase/gnome_default_applications";
{
loadtest "x11/gnomecase/gnome_default_applications" if (is_sle('<16') || is_tumbleweed) ;

sub run {
# Launch 3 applications
ensure_installed('gedit');
my $editor = is_sle('16+') ? "gnome-text-editor" : "gedit";
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor commets,

is_sle(">=16.0") is the same as is_sle('16+'), correct? :)

Copy link
Copy Markdown
Contributor

@rfan1 rfan1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GraceWang571 GraceWang571 force-pushed the sle161-gnome branch 2 times, most recently from 2ba99f0 to 4ef3934 Compare April 8, 2026 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants