Skip to content

PC LTP: Cleanup LTP module installation#25188

Open
pevik wants to merge 2 commits intoos-autoinst:masterfrom
pevik:cleanup-ltp-poc
Open

PC LTP: Cleanup LTP module installation#25188
pevik wants to merge 2 commits intoos-autoinst:masterfrom
pevik:cleanup-ltp-poc

Conversation

@pevik
Copy link
Copy Markdown
Contributor

@pevik pevik commented Apr 2, 2026 •
edited
Loading

POC had 2 ways to build LTP kernel modules. 3d8fe39 introduced make install to the old way, therefore there ere 2 functions doing basically the same. Removing one which called only 'sudo make modules-install' added in 671fb59, because that triggered 'make modules' compilation (only "brave" man compiles as root :)).

TODO PC team: For now keeping both variables PUBLIC_CLOUD_LTP_GIT_BUILD and PUBLIC_CLOUD_LTP_BUILD_MODULES, obviously just one of them is needed. PC team should pick one, adapt test setup (including removing the function which checks the unused one).

Fixes: 3d8fe39 ("LTP: Build modules via make modules")
Fixes: 671fb59 ("Adapt PC to new LTP module building")

@volodymyrkatkalov could you please verify?

@pevik pevik added the qe-c label Apr 2, 2026
@pevik pevik requested a review from volodymyrkatkalov April 2, 2026 08:36
volodymyrkatkalov
volodymyrkatkalov reviewed Apr 2, 2026
View reviewed changes
volodymyrkatkalov
volodymyrkatkalov reviewed Apr 2, 2026
View reviewed changes
@volodymyrkatkalov
Copy link
Copy Markdown
Contributor

volodymyrkatkalov commented Apr 2, 2026 •
edited
Loading

VRs:

@pevik pevik force-pushed the cleanup-ltp-poc branch from 53218db to bac3f3f Compare April 2, 2026 19:42
pevik added 2 commits April 2, 2026 21:44
@pevik
PC LTP: Cleanup LTP module installation
6d2e140 
POC had 2 ways to build LTP kernel modules. 3d8fe39 introduced make
install to the old way, therefore there were 2 functions doing basically
the same. Removing one which called only 'sudo make modules-install'
added in 671fb59, because that triggered 'make modules' compilation
(only "brave" man compiles as root :)).

Fixes: 3d8fe39 ("LTP: Build modules via make modules")
Fixes: 671fb59 ("Adapt PC to new LTP module building")
Signed-off-by: Petr Vorel <pvorel@suse.cz>
@pevik
PC LTP: Remove unused PUBLIC_CLOUD_LTP_GIT_BUILD
d3e9990 
PUBLIC_CLOUD_LTP_GIT_BUILD is not used in gravity-cannon, metadata nor
qac-openqa-yaml.

Suggested-by: Volodymyr Katkalov <volodymyr.katkalov@suse.com>
Signed-off-by: Petr Vorel <pvorel@suse.cz>
@pevik pevik force-pushed the cleanup-ltp-poc branch from bac3f3f to d3e9990 Compare April 2, 2026 19:46
@pevik pevik requested a review from volodymyrkatkalov April 2, 2026 19:48
volodymyrkatkalov
volodymyrkatkalov approved these changes Apr 3, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@volodymyrkatkalov volodymyrkatkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's see VRs

@pevik
Copy link
Copy Markdown
Contributor Author

pevik commented Apr 7, 2026

Thank you for running jobs, obviously installation works and it's safe to merge.

BTW aou run all of them with LTP_COMMAND_EXCLUDE=^(?!ldd01_sh) which causes only ldd01_sh is run. It'd be nice to see at least a single job with LTP_COMMAND_EXCLUDE= LTP_COMMAND_PATTERN='_module|insmod' to actually run tests which use compiled modules: delete_module0[1-3]|{f,}init_module0[12]|insmod01.

@volodymyrkatkalov
Copy link
Copy Markdown
Contributor

volodymyrkatkalov commented Apr 8, 2026

Thank you for running jobs, obviously installation works and it's safe to merge.

BTW aou run all of them with LTP_COMMAND_EXCLUDE=^(?!ldd01_sh) which causes only ldd01_sh is run. It'd be nice to see at least a single job with LTP_COMMAND_EXCLUDE= LTP_COMMAND_PATTERN='_module|insmod' to actually run tests which use compiled modules: delete_module0[1-3]|{f,}init_module0[12]|insmod01.

https://openqa.suse.de/tests/21719280

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@volodymyrkatkalov volodymyrkatkalov volodymyrkatkalov approved these changes

@pdostal pdostal Awaiting requested review from pdostal pdostal is a code owner

@grisu48 grisu48 Awaiting requested review from grisu48 grisu48 is a code owner

@ricardobranco777 ricardobranco777 Awaiting requested review from ricardobranco777 ricardobranco777 is a code owner

@m-dati m-dati Awaiting requested review from m-dati m-dati is a code owner

Assignees

No one assigned

Labels

qe-c

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pevik @volodymyrkatkalov