PC: Move cleanup to dedicated always_run test module#25182
Merged
pdostal merged 7 commits intoos-autoinst:masterfrom Apr 8, 2026
Merged
PC: Move cleanup to dedicated always_run test module#25182pdostal merged 7 commits intoos-autoinst:masterfrom
pdostal merged 7 commits intoos-autoinst:masterfrom
Conversation
pdostal
requested review from
BillAnastasiadis,
alvarocarvajald,
grisu48,
m-dati,
mpagot and
ricardobranco777
as code owners
pdostal
force-pushed
the
new_cleanup
branch
2 times, most recently
from
05cf8dc to
787edc4
Compare
pdostal
force-pushed
the
new_cleanup
branch
2 times, most recently
from
aacca22 to
51b9617
Compare
grisu48
reviewed
Apr 2, 2026
Contributor
grisu48
left a comment
grisu48
left a comment
There was a problem hiding this comment.
Minor nitpicks plus two comments:
- Perhaps we want to keep
ssh_interactive_end.pmas a module which terminates the ssh tunnels but doesn't do the instance cleanup. Leaving resources dangling is technical debt that we can avoid here - I suggest to rename
publiccloud/cleanup.pmtopubliccloud/destroy.pmas it follows the terraform nomenclature. I think this makes it cleared from the module name what is going to happen, but that's just a suggestion.
Contributor
alvarocarvajald
left a comment
alvarocarvajald
left a comment
There was a problem hiding this comment.
Changes generally LGTM, but I think some YAML schedules are missing here. For example sles4sap/publiccloud/qesap_terraform gets loaded from:
- sles4sap_gnome_saptune.yaml
- sles4sap_ibsm_embargo_check.yml
- sles4sap_gnome_saptune_product.yaml
- sles4sap_gnome_saptune_maintenance.yaml
Member
Author
I didn't find any. Can you please help me with that? See: $ rg ssh_interactive_end schedule/sles4sap/
$ |
grisu48
approved these changes
Apr 7, 2026
pdostal
requested review from
Amrysliu,
a-kpappas,
badboywj,
d3flex,
emiura,
jankohoutek,
lilyeyes,
lpalovsky and
mloviska
as code owners
linguini-dev
approved these changes
Apr 7, 2026
Contributor
This VR covers it: https://pdostal-workbench.qe.prg2.suse.org/tests/341 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builddestroy of sle-micro-6.1-EC2-BYOS-Updates.x86_64 slem_basic@ec2_t3a.small 1 3 1 6
Builddestroy of sle-micro-6.1-EC2-BYOS-Updates.x86_64 slem_basic@ec2_t3a.small 1 3 1 6
Builddestroy of sle-15-SP7-Azure-SAP-PAYG-Incidents.x86_64 SAPHanaSR-ScaleUp-PerfOpt@az_Standard_E4s_v3 2 31 1 1
Builddestroy of sle-micro-6.1-EC2-BYOS-Updates.x86_64 publiccloud_download_testrepos@64bit 2
Builddestroy of sle-micro-6.1-EC2-BYOS-Updates.x86_64 publiccloud_download_testrepos@64bit 2
Builddestroy of sle-micro-6.1-EC2-BYOS-Updates.aarch64 publiccloud_download_testrepos@64bit 2
Builddestroy of sle-micro-6.1-EC2-BYOS-Updates.aarch64 publiccloud_ltp@ec2_c6g.large 1 3 1 2
Builddestroy of sle-micro-6.1-EC2-BYOS-Updates.aarch64 publiccloud_slem_containers@ec2_c6g.large 1 3 1 5
Builddestroy of sle-15-SP7-Azure-BYOS-Updates.aarch64 publiccloud_cloud_functional@64bit 7
Builddestroy of sle-16.0-EC2.x86_64 publiccloud_ltp@ec2_t3a.large 2 1
Builddestroy of sle-15-SP7-Azure-Basic-Updates.x86_64 publiccloud_consoletests@64bit 4 21
Builddestroy of sle-15-SP7-Server-DVD-Updates.x86_64 azure_himmelblau@64bit 2
Builddestroy of sle-16.0-EC2.x86_64 publiccloud_btrfstests@ec2_t3a.large 7 1
Builddestroy of sle-15-SP4-Azure-SAP-BYOS-Incidents-saptune.x86_64 sles4sap_gnome_saptune_delete_rename@az_Standard_E4s_v3 1 18
Builddestroy of sle-15-SP7-Server-DVD-Updates.x86_64 publiccloud_tools_cli_ec2@64bit 2
Builddestroy of sle-16.0-EC2.x86_64 publiccloud_img_proof@ec2_m5d.large 23 3
Builddestroy of sle-16.0-EC2.x86_64 publiccloud_smoketests@ec2_i3.large 10
Builddestroy of sle-micro-6.1-Azure-BYOS-Updates.x86_64 publiccloud_ltp@az_Standard_B4ms 4 3 1 2
Builddestroy of sle-16.0-EC2.x86_64 publiccloud_upload_img@64bit 2