PC LTP kernel devel package to match kernel#25166
Merged
ricardobranco777 merged 1 commit intoos-autoinst:masterfrom Apr 8, 2026
Merged
PC LTP kernel devel package to match kernel#25166ricardobranco777 merged 1 commit intoos-autoinst:masterfrom
ricardobranco777 merged 1 commit intoos-autoinst:masterfrom
Conversation
volodymyrkatkalov
force-pushed
the
pc_match_kernel_devel_ver
branch
2 times, most recently
from
bf52cc9 to
1bf169e
Compare
volodymyrkatkalov
requested review from
grisu48,
m-dati,
pdostal and
ricardobranco777
as code owners
Contributor
ricardobranco777
left a comment
ricardobranco777
left a comment
There was a problem hiding this comment.
I think we can get all the information with just one command run through ssh and less Perl like this:
rpm -qf /boot/config-$(uname -r) | sed -e "s/\.$(arch)//" | ...
or even:
rpm -qf /boot/config-$(uname -r) | awk -F- '{ printf "%s-%s-devel", $1, $2 }'
grisu48
reviewed
Apr 1, 2026
grisu48
approved these changes
Apr 1, 2026
volodymyrkatkalov
force-pushed
the
pc_match_kernel_devel_ver
branch
3 times, most recently
from
4069067 to
f9571f8
Compare
Ensure that devel package matches the kernel version before building LTP modules for the targeted kernel - Related ticket: https://progress.opensuse.org/issues/198164
volodymyrkatkalov
force-pushed
the
pc_match_kernel_devel_ver
branch
from
f9571f8 to
efeeba1
Compare
grisu48
approved these changes
Apr 2, 2026
m-dati
reviewed
Apr 8, 2026
| $instance->softreboot(); | ||
| } else { | ||
| zypper_call_remote($instance, cmd => "install --no-recommends " . join(' ', get_required_build_dependencies())); | ||
| zypper_call_remote($instance, cmd => "install --no-recommends " . join(' ', @deps)); |
Contributor
There was a problem hiding this comment.
LGTM, all fine, but this command, even working, is 'formally' incorrect from a language POV. the instance should be set externally as the self pointer:
Suggested change
| zypper_call_remote($instance, cmd => "install --no-recommends " . join(' ', @deps)); | |
| $instance->zypper_call_remote(cmd => "install --no-recommends " . join(' ', @deps)); |
Contributor
Author
There was a problem hiding this comment.
@m-dati I didn't change the way it's called I only changed the array that's passed into the call
Contributor
Author
There was a problem hiding this comment.
About formally incorrect I can include the refinement in next iteration, no problems
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure that devel package matches the kernel version before building LTP modules for the targeted kernel
PUBLIC_CLOUD_LTP_BUILD_MODULES=1):VR after code change