Open
Conversation
This error is shown when strict is enabled:
Global symbol "$incident_repo" requires explicit package name (did you
forget to declare "my $incident_repo"?) at
./tests/console/openssl_nodejs.pm line 44.
Since in that branch the variable `$incident_repo` was never defined,
this can never have been working as expected.
Also it might be easier to just do:
$increment_repo =~ s{/$}{};
perlpunk
force-pushed
the
fix-openssl_nodejs
branch
from
da78646 to
cc2f8d4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This error is shown when strict is enabled:
Since in that branch the variable
$incident_repowas never defined, this can never have been working as expected.Also it might be easier to just do: