feat: Speed up asset uploads#7263
Merged
mergify[bot] merged 3 commits intoos-autoinst:masterfrom Apr 13, 2026
Merged
Conversation
okurz
approved these changes
Apr 10, 2026
perlpunk
approved these changes
Apr 10, 2026
Contributor
perlpunk
left a comment
perlpunk
left a comment
There was a problem hiding this comment.
Tests need to be adjusted.
Maybe I would have conducted some more tests in production, but if turns out problematic, it's easy to fix
Contributor
|
And maybe it would be good to split the refactoring of the constant and the adjustment of the value to different commits. |
perlpunk
previously requested changes
Apr 10, 2026
Martchus
force-pushed
the
upload-junk-size
branch
2 times, most recently
from
36a2958 to
6195322
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7263 +/- ##
=======================================
Coverage 99.97% 99.97%
=======================================
Files 421 421
Lines 44165 44167 +2
=======================================
+ Hits 44152 44154 +2
Misses 13 13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
d3flex
approved these changes
Apr 13, 2026
okurz
approved these changes
Apr 13, 2026
Member
perlpunk
dismissed
their stale review
Others disagree with me, no strong opinion
* Increase default upload junk size from 1 MB to 10 MB (speeds up the upload for me locally by around 35 %) * Adjust `client_body_buffer_size` setting as well adding a little bit of headroom Related ticket: https://progress.opensuse.org/issues/199397
Martchus
force-pushed
the
upload-junk-size
branch
from
6195322 to
bbea743
Compare
perlpunk
previously requested changes
Apr 13, 2026
Martchus
force-pushed
the
upload-junk-size
branch
from
bbea743 to
b5dd1d2
Compare
openqa-git-sync
pushed a commit
to os-autoinst/salt-states-openqa
that referenced
this pull request
Apr 13, 2026
To make full use of the upstream change introduced by os-autoinst/openQA#7263. Related ticket: https://progress.opensuse.org/issues/199397
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
client_body_buffer_sizesetting as well adding a little bit of headroomRelated ticket: https://progress.opensuse.org/issues/199397
I'm adding the "not-ready" label because
I still want to do some local tests and I also need to check whether the NGINX config needs to be changed manually in production. It looks like/etc/nginx/vhosts.d/openqa-endpoints.incis modified on o3 and OSD so we'll have to change those files manually. SoI'll changeI changed the setting there manually.