fix: Apply force result label correctly if force_result_regex is empty#7252
Open
Martchus wants to merge 3 commits intoos-autoinst:masterfrom
Open
fix: Apply force result label correctly if force_result_regex is empty#7252Martchus wants to merge 3 commits intoos-autoinst:masterfrom
force_result_regex is empty#7252Martchus wants to merge 3 commits intoos-autoinst:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7252 +/- ##
=======================================
Coverage 99.95% 99.95%
=======================================
Files 420 420
Lines 44038 44041 +3
=======================================
+ Hits 44016 44019 +3
Misses 22 22 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
perlpunk
reviewed
Apr 8, 2026
This seems to work as-is. I also temporarily removed the code responsible for this in `sub carry_over_bugrefs` which caused the newly added checks to fail. Related ticket: https://progress.opensuse.org/issues/199124
If `force_result_regex` is empty, the behavior explained in https://perldoc.perl.org/perlop#The-empty-pattern-// applies. This means the force result label is not consistently applied as the "description … does not match pattern" case can be wrongly assumed depending on the outcome of a the last regex match. This change fixes that by ignoring the check if `force_result_regex` is empty. Related ticket: https://progress.opensuse.org/issues/199124
* Rewrite the unclear phrasing "If undefined and by default" * Use "apply" instead of "accepted" which makes more sense here * Remove the unclear "no description is expected" part Related ticket: https://progress.opensuse.org/issues/199124
Martchus
force-pushed
the
force-result-carry-over
branch
from
87b0234 to
127725a
Compare
Martchus
changed the title
force_result_regex is empty
perlpunk
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This seems to work as-is. I also temporarily removed the code responsible for this in
sub carry_over_bugrefswhich caused the newly added checks to fail.Related ticket: https://progress.opensuse.org/issues/199124