fix: Reference schema files from the installed package for helm lint#7245
Merged
mergify[bot] merged 1 commit intoos-autoinst:masterfrom Apr 9, 2026
Merged
fix: Reference schema files from the installed package for helm lint#7245mergify[bot] merged 1 commit intoos-autoinst:masterfrom
mergify[bot] merged 1 commit intoos-autoinst:masterfrom
Conversation
Motivation: `make test-helm-lint` failed locally on openSUSE Slowroll as of 2026-03 because `ct` (Chart Testing tool) cannot find the default schema files `chart_schema.yaml` and `lintconf.yaml`. This is likely due to a newer `chart-testing` package (at time of writing problem appears with 3.14.0-1.2), which places these files in a non-standard location (`/usr/share/doc/packages/chart-testing/`) instead of the default search paths (`.`, `~/.ct/`, or `/etc/ct/`). Design Choices: - Updated `tools/test_helm_chart` to check for schema files in the default search locations first. - If not found, it attempts to locate them in the package's documentation directory and passes them explicitly via `--chart-yaml-schema` and `--lint-conf`. - This approach avoids committing large schema files to the repository while ensuring compatibility with the newer system's package layout. Benefits: - Restores the functionality of `make test-helm-lint` for local test runs and/or on newer systems - Ensures robustness across different installation layouts of the `chart-testing` tool.
Martchus
approved these changes
Apr 7, 2026
perlpunk
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
make test-helm-lintfailed locally on openSUSE Slowroll as of 2026-03because
ct(Chart Testing tool) cannot find the default schema fileschart_schema.yamlandlintconf.yaml. This is likely due to a newerchart-testingpackage (at time of writing problem appears with3.14.0-1.2), which places these files in a non-standard location
(
/usr/share/doc/packages/chart-testing/) instead of the default searchpaths (
.,~/.ct/, or/etc/ct/).Design Choices:
tools/test_helm_chartto check for schema files in thedefault search locations first.
documentation directory and passes them explicitly via
--chart-yaml-schemaand--lint-conf.while ensuring compatibility with the newer system's package layout.
Benefits:
make test-helm-lintfor local testruns and/or on newer systems
chart-testingtool.