Skip to content

style: Use grep and map only in block form#7078

Merged
mergify[bot] merged 2 commits intoos-autoinst:masterfrom
perlpunk:require-block-grep-map
Mar 9, 2026
Merged

style: Use grep and map only in block form#7078
mergify[bot] merged 2 commits intoos-autoinst:masterfrom
perlpunk:require-block-grep-map

Conversation

@perlpunk
Copy link
Copy Markdown
Contributor

@perlpunk perlpunk commented Mar 5, 2026

@perlpunk perlpunk changed the title Require block grep map style: Use grep and map only in block form Mar 5, 2026
@perlpunk
Copy link
Copy Markdown
Contributor Author

perlpunk commented Mar 5, 2026

https://app.circleci.com/pipelines/github/os-autoinst/openQA/19721/workflows/b80c43c7-8819-4d0f-bc32-7133c828461f/jobs/196777

Commit b0529f4ea3:
6: B1 Line exceeds max length (81>80): "https://metacpan.org/pod/Perl::Critic::Policy::BuiltinFunctions::RequireBlockGrep"
make: *** [Makefile:395: test-gitlint] Error 1

Am I supposed to break a URL into two pieces because of gitlint?

@perlpunk
Copy link
Copy Markdown
Contributor Author

perlpunk commented Mar 5, 2026

https://app.circleci.com/pipelines/github/os-autoinst/openQA/19721/workflows/b80c43c7-8819-4d0f-bc32-7133c828461f/jobs/196772

    #   Failed test 'exactly one collapse button present'
    #   at t/ui/10-tests_overview.t line 213.
    #          got: '0'
    #     expected: '1'
    # Looks like you failed 1 test of 32.

#   Failed test 'stacking of parallel children'
#   at t/ui/10-tests_overview.t line 224.
# Looks like you failed 1 test of 38.
[15:47:01] t/ui/10-tests_overview.t ................... 
Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/38 subtests 

but that test passes for me locally. Retriggering.

@perlpunk
Copy link
Copy Markdown
Contributor Author

perlpunk commented Mar 6, 2026

It's not urgent, but how can I avoid the gitlint error?

@perlpunk
Copy link
Copy Markdown
Contributor Author

perlpunk commented Mar 6, 2026

Also, I sometimes add log lines to a commit message, and having to wrap those is not always a good idea.

@okurz
Copy link
Copy Markdown
Member

okurz commented Mar 6, 2026

It's not urgent, but how can I avoid the gitlint error?

->

@perlpunk perlpunk force-pushed the require-block-grep-map branch from 27560bd to 51c63e5 Compare March 9, 2026 09:34
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.72%. Comparing base (ead9b8b) to head (51c63e5).
⚠️ Report is 9 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7078   +/-   ##
=======================================
  Coverage   99.72%   99.72%           
=======================================
  Files         416      416           
  Lines       43076    43078    +2     
=======================================
+ Hits        42956    42958    +2     
  Misses        120      120           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@perlpunk perlpunk removed the not-ready label Mar 9, 2026
@perlpunk
Copy link
Copy Markdown
Contributor Author

perlpunk commented Mar 9, 2026

@Mergifyio refresh

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Mar 9, 2026

refresh

✅ Pull request refreshed

@mergify mergify bot merged commit 39d80a9 into os-autoinst:master Mar 9, 2026
50 checks passed
@perlpunk perlpunk deleted the require-block-grep-map branch March 9, 2026 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants