style: Use grep and map only in block form#7078
Merged
mergify[bot] merged 2 commits intoos-autoinst:masterfrom Mar 9, 2026
Merged
style: Use grep and map only in block form#7078mergify[bot] merged 2 commits intoos-autoinst:masterfrom
mergify[bot] merged 2 commits intoos-autoinst:masterfrom
Conversation
Contributor
Author
Am I supposed to break a URL into two pieces because of gitlint? |
okurz
approved these changes
Mar 5, 2026
Contributor
Author
but that test passes for me locally. Retriggering. |
Martchus
approved these changes
Mar 6, 2026
Contributor
Author
|
It's not urgent, but how can I avoid the gitlint error? |
Contributor
Author
|
Also, I sometimes add log lines to a commit message, and having to wrap those is not always a good idea. |
Member
-> |
It's easier to see where it starts and ends. Can be enforced later by https://metacpan.org/pod/Perl::Critic::Policy::BuiltinFunctions::RequireBlockGrep
It's easier to see where it starts and ends. Can be enforced later by https://metacpan.org/pod/Perl::Critic::Policy::BuiltinFunctions::RequireBlockMap
27560bd to
51c63e5
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7078 +/- ##
=======================================
Coverage 99.72% 99.72%
=======================================
Files 416 416
Lines 43076 43078 +2
=======================================
+ Hits 42956 42958 +2
Misses 120 120 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
@Mergifyio refresh |
Contributor
✅ Pull request refreshed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See also #7056