PART 2: Slightly modernize the look - After #7072#7069
PART 2: Slightly modernize the look - After #7072#7069okurz wants to merge 10 commits intoos-autoinst:masterfrom
Conversation
|
Great PR! Please pay attention to the following items before merging: Files matching
This is an automatically generated QA checklist based on modified files. |
19c8dce to
2ea54c7
Compare
Martchus
left a comment
There was a problem hiding this comment.
Changes I would rather revert:
- The old navbar wasted less space and I liked the bigger openQA icon more.
Changes I find ok:
- The old accent color looked better but I guess it doesn't make a big difference.
Changes I liked:
- The new navbar and menu borders/shadows look better.
- The new jumbotron background in darkmode looks better but the SUSE font color needs to be adjusted for better contrast.
| .h4, | ||
| .h5, | ||
| .h6 { | ||
| font-family: inherit; |
There was a problem hiding this comment.
Please keep these in one line.
There was a problem hiding this comment.
I formatted files automatically with prettier. Your comment brought me to the idea to bring in such automated style changes first. I think it's easier if we first discuss the style in this new PR when we no that only whitespace changes are applied. Then I will rebase which will make this PR's changes easier to read. See
| .tooltip .tooltip-inner { | ||
| max-width: 400px; | ||
| p { | ||
| margin-bottom: 2px; | ||
| } | ||
| ul { | ||
| padding-left: 1.2rem; | ||
| } | ||
| p, ul { | ||
| text-align: left; | ||
| word-break: break-word; | ||
| } | ||
| max-width: 25rem; | ||
| text-align: left; | ||
| p { | ||
| margin-bottom: 0.125rem; | ||
| } | ||
| ul { | ||
| padding-left: 1.25rem; | ||
| } | ||
| } |
There was a problem hiding this comment.
This isn't shown on any of the screenshots. What is the improvement/change here?
There was a problem hiding this comment.
Using more relative measurements rather than fixed ones. I must say I did not check all changes visually as I assume there is generally no significant impact on normal zoom levels.
Those are actually also the two biggest issues I see with it :) I will see what I can about it.
please clarify what you mean with "accent color"
👍 |
|
Regarding missing OBS checks: I can't get them redelivered, but the OBS project is there, so we can look at it manually before merging: https://build.opensuse.org/package/show/devel:openQA:GitHub:os-autoinst:openQA:PR-7069/openQA The initial PR creation is too old to redeliver the webhook. |
38c579a to
46f1586
Compare
46f1586 to
2e660af
Compare
|
This pull request is now in conflicts. Could you fix it? 🙏 |
2e660af to
27af73e
Compare
Refactor openqa_theme.scss to use native Bootstrap 5 maps and variables. This ensures better compatibility with Bootstrap 5 native color modes and modern CSS practices while maintaining backward compatibility for existing SCSS files through variable aliasing.
Update overall.scss to leverage Bootstrap 5 CSS variables for cards, tabs, and headings. This improves dark mode consistency and introduces a more contemporary look with subtle shadows and improved spacing. Includes a fix for body margin to prevent the footer from overlapping interactive elements in UI tests.
Refresh the navigation bar and dropdown menus using modern BS5 patterns. Introduces border-radius for links and improved dropdown shadows. Retains specific vertical padding at larger breakpoints to maintain compatibility with Selenium tests that expect exact element positioning.
Replace legacy Bootstrap classes (.jumbotron, .hidden-sm-down) with modern utility equivalents. The .jumbotron class is preserved as a secondary class to maintain compatibility with existing JavaScript and UI tests.
Replace .card-outline-secondary with BS5 native .border-secondary in the live view template.
- Remove deprecated .navbar-light from navbar template to allow BS5 color modes. - Define explicit navbar CSS variables for dark mode in overall.scss. - Ensure nav-links stay bright and visible when selected or hovered in dark mode. - Improve general link and primary color contrast for dark mode.
- Restore lightweight heading weights (font-weight: 400) to match original UI. - Centralize dark mode primary color and font weight in openqa_theme.scss. - Eliminate hardcoded hex values and use SCSS functions for RGB variables. - Convert remaining px spacing to rem for better accessibility and scaling. - Clean up navigation SCSS by removing specificity overrides and using global variables.
Refine the main dashboard welcome area by reducing redundant nested padding (from ~96px to ~30px). This restores the balance of the original design while maintaining the modern Bootstrap 5 aesthetic.
- Prevent prettier from formatting multi-selector heading rules across multiple lines to maintain compactness as requested in PR review. - Revert tooltip styling changes as they are unneeded and not shown in screenshots.
- Remove single-line heading exclusions from overall.scss. - Update npm scripts to include Prettier auto-formatting and linting for .scss files during 'make tidy-js'. - Apply Prettier formatting across all .scss files in assets/stylesheets to enforce a consistent codebase style.
27af73e to
df75230
Compare
Screenshots for comparison: Old left - new Right
After: