test: Move author tests to xt/ and rename target to test-author#7068
Draft
okurz wants to merge 3 commits intoos-autoinst:masterfrom
Draft
test: Move author tests to xt/ and rename target to test-author#7068okurz wants to merge 3 commits intoos-autoinst:masterfrom
okurz wants to merge 3 commits intoos-autoinst:masterfrom
Conversation
okurz
force-pushed
the
feature/036_move_author_tests_to_xt
branch
from
2204f43 to
3adee5b
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
okurz
force-pushed
the
feature/036_move_author_tests_to_xt
branch
from
3adee5b to
ad8ab9c
Compare
okurz
added a commit
to okurz/os-autoinst-common
that referenced
this pull request
Mar 14, 2026
okurz
changed the title
okurz
changed the title
okurz
force-pushed
the
feature/036_move_author_tests_to_xt
branch
3 times, most recently
from
25cc52c to
e4644c4
Compare
perlpunk
reviewed
Mar 17, 2026
okurz
force-pushed
the
feature/036_move_author_tests_to_xt
branch
2 times, most recently
from
1b00dc0 to
6fbabde
Compare
okurz
force-pushed
the
feature/036_move_author_tests_to_xt
branch
3 times, most recently
from
8178437 to
9155e43
Compare
okurz
changed the title
okurz
force-pushed
the
feature/036_move_author_tests_to_xt
branch
from
9155e43 to
8f51966
Compare
okurz
changed the title
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
okurz
force-pushed
the
feature/036_move_author_tests_to_xt
branch
from
8f51966 to
e137ddf
Compare
okurz
force-pushed
the
feature/036_move_author_tests_to_xt
branch
2 times, most recently
from
8e66d25 to
73fdb8d
Compare
okurz
changed the title
okurz
force-pushed
the
feature/036_move_author_tests_to_xt
branch
from
73fdb8d to
261c1b5
Compare
okurz
force-pushed
the
feature/036_move_author_tests_to_xt
branch
from
261c1b5 to
6919290
Compare
okurz
force-pushed
the
feature/036_move_author_tests_to_xt
branch
from
6919290 to
fa075f6
Compare
okurz
force-pushed
the
feature/036_move_author_tests_to_xt
branch
from
fa075f6 to
1ccb628
Compare
okurz
changed the title
okurz
force-pushed
the
feature/036_move_author_tests_to_xt
branch
from
1ccb628 to
d95df91
Compare
Motivation: Following Perl ecosystem best practices, author tests (static analysis, style checks, POD, etc.) should be separated from functional/dynamic tests. This allows build environments and package maintainers to focus exclusively on tests that verify the correctness of the software in its runtime environment, while avoiding dependencies and runtime overhead associated with developer-only quality gates. Furthermore, compiling the entire codebase via `01-compile-check-all.t` takes exceptionally long when running alongside other tests because it gets instrumented by `Devel::Cover`. Separating it into its own directory allows us to isolate it and bypass the coverage overhead. Design Choices: - Moved 00-tidy.t, 01-style.t, 02-pod.t, and 45-make-update-deps.t from t/ to xt/. - Moved 01-compile-check-all.t from t/ to t/compile/. - Renamed the Makefile target 'test-tidy-compile-style' to 'test-author' to match industry-standard naming and ensure consistency with the 'os-autoinst-common' sub-module. - Added a new 'test-compile' Makefile target for the compile checks. - Set COVEROPT="" on both 'test-author' and 'test-compile' targets to bypass Devel::Cover instrumentation, drastically speeding up execution. - Updated t/01-compile-check-all.t to include the new xt/ directory in its syntax checks. - Updated xt/01-style.t to include xt/ in style checks and correctly exclude itself from self-referential style rules. - Simplified Makefile targets (test-t, test-ui, test-api) by removing GLOBIGNORE exclusions for moved tests, as they are naturally isolated. - Updated t/testrules.yml to reflect the new test locations. - Simplified dist/rpm/openQA.spec as author tests can be ignored completely. - Updated `prove_wrapper` in CI tools to support new directories. User Benefit: - Developers get much faster feedback via 'make test-author' and 'make test-compile' due to bypassing Devel::Cover. - CI and build environments can more easily exclude non-functional tests, speeding up build-time verification and reducing dependency bloat. - Improved project structure consistency with other projects in the os-autoinst ecosystem.
Motivation: Compiling the entire codebase (`01-compile-check-all.t`) is functionally a dynamic test that requires all application dependencies to be fully installed. It logically does not belong with static `checkstyle` tools (like yamllint, perltidy) which do not execute application code. Furthermore, isolating it into its own CI job allows it to run concurrently alongside both static analysis and standard unit testing, lowering total pipeline execution time. Design Choices: - Moved `test-compile` out of the `test-checkstyle` Makefile target. - Added a dedicated `compile` job to `.circleci/config.yml` workflow. User Benefits: - Developers running `make test-checkstyle` get instant feedback on linting and style errors without waiting for a full module compile. - Improved CI execution parallelism.
okurz
force-pushed
the
feature/036_move_author_tests_to_xt
branch
from
d95df91 to
2bc8fa6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
Following Perl ecosystem best practices, author tests (static analysis,
style checks, POD, etc.) should be separated from functional/dynamic
tests. This allows build environments and package maintainers to focus
exclusively on tests that verify the correctness of the software in its
runtime environment, while avoiding dependencies and runtime overhead
associated with developer-only quality gates.
A similar change was done in os-autoinst in os-autoinst commit 090ad748
in PR os-autoinst/os-autoinst#1596. We already
had a Makefile target called "tidy-compile-style" which sounds like
"author" tests.
Design Choices:
45-make-update-deps.t from t/ to xt/.
to match industry-standard naming and ensure consistency with the
'os-autoinst-common' sub-module.
its syntax checks.
exclude itself from self-referential style rules.
GLOBIGNORE exclusions for moved tests, as they are no longer in t/.
completely.
User Benefit:
tests, speeding up build-time verification and reducing dependency
bloat.
os-autoinst ecosystem.