Skip to content

RFC: Include core perlcritic rules as well #7056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
perlpunk wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

RFC: Include core perlcritic rules as well #7056

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions .perlcriticrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,14 @@
theme = community + openqa
severity = 4
theme = community + openqa + core
severity = 1
include = strict ValuesAndExpressions::ProhibitInterpolationOfLiterals CodeLayout::ProhibitParensWithBuiltins BuiltinFunctions::RequireBlockMap BuiltinFunctions::ProhibitStringySplit ControlStructures::ProhibitNegativeExpressionsInUnlessAndUntilConditions
exclude = Subroutines::ProhibitExplicitReturnUndef Subroutines::ProhibitSubroutinePrototypes Subroutines::RequireFinalReturn Subroutines::ProhibitBuiltinHomonyms ValuesAndExpressions::ProhibitConstantPragma ControlStructures::ProhibitPostfixControls RegularExpressions::RequireLineBoundaryMatching RegularExpressions::RequireExtendedFormatting RegularExpressions::RequireDotMatchAnything ValuesAndExpressions::RequireInterpolationOfMetachars References::ProhibitDoubleSigils Modules::RequireVersionVar ValuesAndExpressions::ProhibitLongChainsOfMethodCalls ValuesAndExpressions::ProhibitEmptyQuotes Documentation::RequirePodSections RegularExpressions::ProhibitUnusualDelimiters ControlStructures::ProhibitUnlessBlocks NamingConventions::Capitalization

verbose = ::warning file=%f,line=%l,col=%c,title=%m - severity %s::[%p] %e\n

# ControlStructures::ProhibitNegativeExpressionsInUnlessAndUntilConditions
# No operators like < =~ ! allowed in 'unless' or 'until', only simple
# unless $x && @$y

verbose = ::warning file=%f,line=%l,col=%c,title=%m - severity %s::[%p] %e\n

# == Perlcritic Policies
# -- Test::Most brings in strict & warnings
[TestingAndDebugging::RequireUseStrict]
Expand Down Expand Up @@ -51,3 +52,7 @@ severity = 5
# -- Superfluous use strict/warning.
[OpenQA::RedundantStrictWarning]
equivalent_modules = Test::Most

[ValuesAndExpressions::ProhibitMagicNumbers]
allowed_values = 0.5 -10 -2 -1 0 1 2 3 4 5 6 7 8 9 10 100 127 128 255 1000 1024 80 443
allowed_types = Hex Octal Float
Loading