fix(immoscout): support buy-side (-kaufen) apartment sub-type SEO URLs#370
Open
Kavlahkaff wants to merge 1 commit into
Open
fix(immoscout): support buy-side (-kaufen) apartment sub-type SEO URLs#370Kavlahkaff wants to merge 1 commit into
Kavlahkaff wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! First of all, thanks a lot for open-sourcing this project!
I found this error when setting up a job on my machine and opened this PR to resolve it. Happy to make any changes if needed!
Refactored
WEB_PATH_TO_APARTMENT_EQUIPMENT_MAPto dynamically generate both-mietenand-kaufenvariants from a sharedBASE_SLUGSmap.Updated the fallback logic in
convertWebToMobileto properly assignapartmentbuyinstead ofapartmentrentwhen the SEO path ends in-kaufen.Added offline test cases to verify the translation of added buy-side slugs.
Closes: #369