Closed
Conversation
Adds timeout to document symbol requests Fixes potential indefinite hang by adding a timeout parameter to document symbol requests. Ensures the operation fails gracefully if it exceeds the set duration.
Introduces default timeout values to prevent indefinite hangs during asynchronous operations in language server methods. Updates include: - Setting a default timeout for document symbol requests when `self.timeout` is unspecified. - Adding timeout handling with error logging for OmniSharp capabilities (`definition_available` and `references_available`). - Passing timeout parameter to `index_repository` in the Serena agent. Improves reliability by avoiding potential blocking issues.
Updates `index_repository` to conditionally handle a timeout parameter based on the server type. Adds timeouts for waiting on OmniSharp capabilities to prevent indefinite hangs, logging warnings if the timeout is exceeded.
Enhances repository indexing by refining error handling, progress tracking, and cache saving logic, ensuring failed files are logged and indexed efficiently. Adjusts checkpoint frequency to improve performance. Adds a timeout mechanism for language server requests to prevent indefinite blocking, raising a clear error if the server fails to respond within 30 seconds.
Enhances server communication logic by adding timeout handling for waiting on completions and reading process streams. Improves logging to provide better insights into failures, including timeouts and invalid headers. Uses unbuffered I/O for better real-time interaction. Fixes potential indefinite waits and unexpected EOF errors during language server communication.
Introduces mechanisms to track and clean up abandoned requests in the language server. Enhances robustness by: - Ignoring late responses to timed-out requests. - Preventing memory leaks through periodic cleanup of old abandoned request IDs. - Logging for better traceability of abandoned and unknown requests. Fixes potential desynchronization issues caused by request timeouts.
Enhances EOFError handling to include process exit codes and stderr messages for better diagnostics. Updates logic to capture additional error details when processes terminate unexpectedly, aiding debugging and troubleshooting.
Conflicts: src/solidlsp/language_servers/omnisharp/omnisharp.py src/solidlsp/ls.py src/solidlsp/ls_handler.py
|
Looks like there are a few issues preventing this PR from being merged!
If you'd like me to help, just leave a comment, like
Feel free to include any additional details that might help me get this PR into a better state. You can manage your notification settings |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.