Enable Rego tests on Windows (Regal v0.39.0 fixes upstream path handling)#1114
Merged
MischaPanch merged 2 commits intooraios:mainfrom Mar 4, 2026
Merged
Conversation
- Bump Regal from v0.36.1 to v0.39.0 which includes Windows path fixes (upstream fix: open-policy-agent/regal#1683) - Remove sys.platform == "win32" skipif from TestRegoLanguageServer Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Picks up FSharp/dotnet handling fixes from oraios#1115 and global memories feature from oraios#1091. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
|
Nice, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@pytest.mark.skipif(sys.platform == "win32", ...)guard fromTestRegoLanguageServer— thesysimport is also cleaned up as it's no longer neededBackground
PR #670 added Rego language support but had to skip all tests on Windows due to a Regal LSP bug where Windows paths were not parsed correctly (
file://D:\...instead offile:///D:/...). The Regal team confirmed the fix and shipped it in v0.37.0 (November 6, 2025). We're upgrading to the latest stable v0.39.0.Test plan
regal_server.py