Skip to content

Some notebook fixes#96

Merged
opcode81 merged 9 commits intooraios:developfrom
mdbenito:fix/pl-notebook
Feb 24, 2026
Merged

Some notebook fixes#96
opcode81 merged 9 commits intooraios:developfrom
mdbenito:fix/pl-notebook

Conversation

@mdbenito
Copy link
Contributor

@mdbenito mdbenito commented Feb 23, 2026

This PR

  • partially addresses Update notebooks to v1 and re-enable them for the docs build #72
  • updates a few old camelCase parameters and function names to the newer snake_case variants.
  • updates the pytorch lightning notebook so that it runs. Adds shuffle=False to the val/test data loaders as per pytorch-lightning's recommendation.
  • updates the old intro notebook so that it runs. Update: the failing check seems to be CI-related (works-on-my-machine™), possibly some issue with clearML starting up? I haven't investigated yet
  • fixes some parameter usages in the clustering notebook (untested beyond IDE warnings, this was mostly a byproduct).

I am aware that it would be better to do this systematically notebook by notebook, but I just read the one two and thought it might be worth sharing the fixes anyway.

@opcode81
Copy link
Collaborator

opcode81 commented Feb 24, 2026

@mdbenito thanks for these fixes.

The right action to take for intro_old.ipynb is actually to delete it. It is superseded by 1-vector-models.ipynb.

tensor_models_pytorch_lightning.ipynb and the entire tensor_model subpackage are also deprecated and probably should be deleted. TorchVector*Model is extremely flexible and can do everything that this sub-package was originally intended for. Specifically, these abstractions support input tensorisers and output tensorisers, which renders them fully capable of handling tensors in (almost) all shapes and forms. See, for instance,

Even though you granted the right to edit the PR, I cannot push updates for some reason.

@mdbenito
Copy link
Contributor Author

Deleted. The other notebook contains indeed a superset of intro_old. 👍🏽

@opcode81
Copy link
Collaborator

Many thanks! Merging...

@opcode81 opcode81 merged commit eed69a6 into oraios:develop Feb 24, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants