You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
updates a few old camelCase parameters and function names to the newer snake_case variants.
updates the pytorch lightning notebook so that it runs. Adds shuffle=False to the val/test data loaders as per pytorch-lightning's recommendation.
updates the old intro notebook so that it runs. Update: the failing check seems to be CI-related (works-on-my-machine™), possibly some issue with clearML starting up? I haven't investigated yet
fixes some parameter usages in the clustering notebook (untested beyond IDE warnings, this was mostly a byproduct).
I am aware that it would be better to do this systematically notebook by notebook, but I just read the one two and thought it might be worth sharing the fixes anyway.
The right action to take for intro_old.ipynb is actually to delete it. It is superseded by 1-vector-models.ipynb.
tensor_models_pytorch_lightning.ipynb and the entire tensor_model subpackage are also deprecated and probably should be deleted. TorchVector*Model is extremely flexible and can do everything that this sub-package was originally intended for. Specifically, these abstractions support input tensorisers and output tensorisers, which renders them fully capable of handling tensors in (almost) all shapes and forms. See, for instance,
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
camelCaseparameters and function names to the newersnake_casevariants.shuffle=Falseto the val/test data loaders as per pytorch-lightning's recommendation.I am aware that it would be better to do this systematically notebook by notebook, but I just read the
onetwo and thought it might be worth sharing the fixes anyway.