Fix missing requirement for uri #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When loading configuration from an option file (using OpenSearch::CLI#load, which rely on OptionParser#load) and `uri` is not loaded, an undefined method exception is raised when an `url` option is parsed, but that exception is captured by the OptionParser logic resulting in the option file to be completely ignored. While #load return false to indicate the failure, consumers of the library are unlikely to check it because end users may or may not rely on option files. Unconditionally require uri to avoid this issue.
Style/SuperArguments: Call `super` without arguments and parentheses when all positional and keyword arguments are forwarded.
Newer versions of steep can detect issues that the standard gem does not allow us to ignore at the moment.
smortex
force-pushed
the
fix-require-uri
branch
from
0e0a877 to
f0c570d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When loading configuration from an option file (using
OpenSearch::CLI#load, which rely onOptionParser#load) anduriis not loaded, an undefined method exception is raised when anurloption is parsed, but that exception is captured by theOptionParserlogic resulting in the option file to be completely ignored.While
#loadreturn false to indicate the failure, consumers of the library are unlikely to check it because end users may or may not rely on option files.Unconditionally require
urito avoid this issue.