PAXEXAM-794: add skip to start/stop.#50
Open
bimargulies wants to merge 1 commit intoops4j:masterfrom
bimargulies:paxexam-794-skip
Open
PAXEXAM-794: add skip to start/stop.#50bimargulies wants to merge 1 commit intoops4j:masterfrom bimargulies:paxexam-794-skip
bimargulies wants to merge 1 commit intoops4j:masterfrom
bimargulies:paxexam-794-skip
Conversation
Member
|
@bimargulies would you still like this to be merged? BTW, I saw that you're a committer on apache/maven-plugins - would you be willing to merge my apache/maven-plugins#109 "in exchange" ? Sorry for horse trading! ;-) |
vorburger
requested changes
Apr 8, 2017
Member
vorburger
left a comment
vorburger
left a comment
There was a problem hiding this comment.
@bimargulies how about this (and a rebase), as per e.g. git-commit-id/git-commit-id-maven-plugin#268 ?
| /** | ||
| * If true, skip execution. | ||
| */ | ||
| @Parameter |
Member
There was a problem hiding this comment.
@parameter(property = "maven.paxexam.start.skip", defaultValue = "false") ?
| /** | ||
| * If true, skip execution. | ||
| */ | ||
| @Parameter |
Member
There was a problem hiding this comment.
@parameter(property = "maven.paxexam.stop.skip", defaultValue = "false") ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.