Skip to content

Improve expiration handling in luci.c#8338

Open
nettnikl wants to merge 3 commits intoopenwrt:masterfrom
nettnikl:patch-1
Open

Improve expiration handling in luci.c#8338
nettnikl wants to merge 3 commits intoopenwrt:masterfrom
nettnikl:patch-1

Conversation

@nettnikl
Copy link

@nettnikl nettnikl commented Feb 21, 2026

Refactor expiration logic to handle relative durations (as in dnsmasq with HAVE_BROKEN_RTC).

Fixes #8337

  • This PR is not from my main or master branch 💩, but a separate branch ✅
  • Each commit has a valid ✒️ Signed-off-by: <my@email.address> row (via git commit --signoff)
  • Each commit and PR title has a valid 📝 <package name>: title first line subject for packages
  • Incremented 🆙 any PKG_VERSION in the Makefile
  • Tested on: (architecture, openwrt version, browser) ✅
  • ( Preferred ) Mention: @ the original code author for feedback
  • ( Preferred ) Screenshot or mp4 of changes:
  • ( Optional ) Closes: e.g. openwrt/luci#issue-number
  • ( Optional ) Depends on: e.g. openwrt/packages#pr-number in sister repo
  • Description: (describe the changes proposed in this PR)

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@nettnikl
Copy link
Author

nettnikl commented Feb 21, 2026

Before i forget, before merge, same change needs to be applied to cgi-bin/luci/admin/network/dhcp i suppose - atleast in case we need to change frontend code

Refactor expiration logic to handle relative durations
(as in dnsmasq with HAVE_BROKEN_RTC).

Signed-off-by: Niklas J. Nett <niklas.j.nett@disroot.org>
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

Use hasSystemFeature to distinguish dnsmasqs lease state format

Signed-off-by: Niklas J. Nett <niklas.j.nett@disroot.org>
Properly check dnsmasq compile options

Signed-off-by: Niklas J. Nett <niklas.j.nett@disroot.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

rpcd-mod-luci: Fix wronlgy displayed "expire" for active leases with HAVE_BROKEN_RTC in dnsmasq enabled

1 participant