luci-app-smart-reboot: add LuCI frontend for smart-reboot#8328
Open
minicom365 wants to merge 1 commit intoopenwrt:masterfrom
Open
luci-app-smart-reboot: add LuCI frontend for smart-reboot#8328minicom365 wants to merge 1 commit intoopenwrt:masterfrom
minicom365 wants to merge 1 commit intoopenwrt:masterfrom
Conversation
This comment has been minimized.
This comment has been minimized.
minicom365
force-pushed
the
luci-app-smart-reboot
branch
2 times, most recently
from
999d37f to
6c8caf4
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
minicom365
force-pushed
the
luci-app-smart-reboot
branch
3 times, most recently
from
46e1e52 to
8fd2331
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Add LuCI UI for configuring smart-reboot. - Enable/disable toggle and HH:MM reboot time input - Interface selection with select-all option - Show last automatic reboot timestamp - Provide i18n catalogs for 18 languages Signed-off-by: 최민 <3387910@naver.com>
minicom365
force-pushed
the
luci-app-smart-reboot
branch
from
8fd2331 to
1682278
Compare
Failed checksIssues marked with an ❌ are failing checks. Commit 1682278
For more details, see the full job log. Something broken? Consider providing feedback. |
minicom365
commented
Feb 25, 2026
Author
minicom365
left a comment
minicom365
left a comment
There was a problem hiding this comment.
Implemented all suggested ucode API replacements in smart-reboot-check.
- replaced the
lockshell command withfs.open()+file.lock()/lock("u")and a cleanup helper - removed every
system("lock -u …")occurrence, now using the native handle - swapped
system("sleep …")for the builtinsleep(milliseconds)function
These changes appear in the new commits on both the local repo and the packages branch (see commit c41ab4e6f on the packages PR). All existing review threads can be considered resolved. Thanks for the pointers!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds LuCI support for
smart-reboot.Features
HH:MM)i18n Languages
ko,ja,zh_Hans,zh_Hant,de,fr,es,it,pt_BR,ru,uk,vi,th,id,tr,pl,nl,arTesting
ipq806x/genericDependency
Signed-off-by: minicom365 3387910@naver.com