luci-mod-network: dns.js: move some related options to cache tab#8314
luci-mod-network: dns.js: move some related options to cache tab#8314saldry wants to merge 1 commit intoopenwrt:masterfrom
Conversation
This comment has been minimized.
This comment has been minimized.
improved the help text of nonegcache and min_cache_ttl added datatype limit to min_cache_ttl and max_cache_ttl Signed-off-by: Fengyu Wu <saldry@proton.me>
Failed checksIssues marked with an ❌ are failing checks. Commit 57fd4b9
For more details, see the full job log. Something broken? Consider providing feedback. |
|
Perhaps it's an opinion, but I chose to put nonegcache not in the cache tab, since dnsmasq 'filters out' those replies. But I suppose all 'cache' entries could live under the cache tab. The 'limits' cache entries do just as well under both tabs. But it's one or the other without a bit more magic. |
|
"Cache" is a more clear and specific subject/topic, while "limit" not. So I prefer cache. Actually, there are only dnsforwardmax and ednspacket_max left in "limit" after removing these cache options. Maybe they can also move to other tabs(dnsforwardmax to "general" or "forward", renaming "DNSSEC" to "EDNS" and adding ednspacket_max). For nonegcache, the filtering is performed internally and does not affect/change a dns response. So I think "cache" is better. Personal opinion, for reference only. |
Signed-off-by: <my@email.address>row (viagit commit --signoff)<package name>: titlefirst line subject for packagesPKG_VERSIONin the MakefileOriginally part of #8102