Skip to content

luci-mod-network: dns.js: move some related options to cache tab#8314

Open
saldry wants to merge 1 commit intoopenwrt:masterfrom
saldry:dnscache
Open

luci-mod-network: dns.js: move some related options to cache tab#8314
saldry wants to merge 1 commit intoopenwrt:masterfrom
saldry:dnscache

Conversation

@saldry
Copy link
Contributor

@saldry saldry commented Feb 9, 2026

  • This PR is not from my main or master branch 💩, but a separate branch ✅
  • Each commit has a valid ✒️ Signed-off-by: <my@email.address> row (via git commit --signoff)
  • Each commit and PR title has a valid 📝 <package name>: title first line subject for packages
  • Incremented 🆙 any PKG_VERSION in the Makefile
  • Tested on: (x86, openwrt SNAPSHOT, Chrome 144) ✅
  • ( Preferred ) Mention: @ the original code author for feedback
  • ( Preferred ) Screenshot or mp4 of changes:
  • ( Optional ) Closes: e.g. openwrt/luci#issue-number
  • ( Optional ) Depends on: e.g. openwrt/packages#pr-number in sister repo
  • Description: (describe the changes proposed in this PR)

Originally part of #8102

  • nonegcache, cachesize, min_cache_ttl and max_cache_ttl are moved to cache tab
  • improved the help text of nonegcache and min_cache_ttl
  • added datatype limit to min_cache_ttl and max_cache_ttl

@github-actions

This comment has been minimized.

improved the help text of nonegcache and min_cache_ttl

added datatype limit to min_cache_ttl and max_cache_ttl

Signed-off-by: Fengyu Wu <saldry@proton.me>
@github-actions
Copy link

github-actions bot commented Feb 9, 2026

Warning

Some formality checks failed.

Consider (re)reading submissions guidelines.

Failed checks

Issues marked with an ❌ are failing checks.

Commit 57fd4b9

  • 🔶 Commit subject length: recommended max 50, required max 60 characters

For more details, see the full job log.

Something broken? Consider providing feedback.

@systemcrash
Copy link
Contributor

Perhaps it's an opinion, but I chose to put nonegcache not in the cache tab, since dnsmasq 'filters out' those replies. But I suppose all 'cache' entries could live under the cache tab. The 'limits' cache entries do just as well under both tabs. But it's one or the other without a bit more magic.

@saldry
Copy link
Contributor Author

saldry commented Feb 9, 2026

"Cache" is a more clear and specific subject/topic, while "limit" not. So I prefer cache. Actually, there are only dnsforwardmax and ednspacket_max left in "limit" after removing these cache options. Maybe they can also move to other tabs(dnsforwardmax to "general" or "forward", renaming "DNSSEC" to "EDNS" and adding ednspacket_max).

For nonegcache, the filtering is performed internally and does not affect/change a dns response. So I think "cache" is better.

Personal opinion, for reference only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants