luci-mod-network: add autoneg and duplex options#8270
Open
sion-111 wants to merge 1 commit intoopenwrt:masterfrom
Open
luci-mod-network: add autoneg and duplex options#8270sion-111 wants to merge 1 commit intoopenwrt:masterfrom
sion-111 wants to merge 1 commit intoopenwrt:masterfrom
Conversation
feckert
reviewed
Jan 27, 2026
| o.datatype = 'uinteger'; | ||
|
|
||
|
|
||
| o = this.replaceOption(s, 'devgeneral', form.ListValue, 'autoneg', _('Auto negotiation')); |
Member
There was a problem hiding this comment.
The documentation sayes that this is a string. However, the option is actually a Boolean and therefore a flag in Luci.
If the option is not set, 1 is assumed, and should not be saved in the configuration. As this is the standard for autneg and duplex nowadays.
Contributor
There was a problem hiding this comment.
For devs not familiar with the luci formats, this is a viable way of handling a boolean, but it's much more 'clicking' than just a Flag. Flag is preferred 👍
This comment has been minimized.
This comment has been minimized.
Add Auto negotiation and Duplex options to the device settings form. Signed-off-by: sion-111 <s.piotrowski91@gmail.com>
5c71cb9 to
b219d5f
Compare
Failed checksIssues marked with an ❌ are failing checks. Commit b219d5f
For more details, see the full job log. Something broken? Consider providing feedback. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: sion-111 <s.piotrowski91@gmail.com><package name>: titlefirst line subjectPKG_VERSIONin the Makefile (not applicable)Description
This change adds Auto negotiation and Duplex options to device settings
in LuCI network configuration.
Leaving the value empty keeps the default kernel behavior.
Tested on Banana Pi BPI-R4.