Skip to content

luci-mod-network: add autoneg and duplex options#8270

Open
sion-111 wants to merge 1 commit intoopenwrt:masterfrom
sion-111:luci-mod-network-autoneg
Open

luci-mod-network: add autoneg and duplex options#8270
sion-111 wants to merge 1 commit intoopenwrt:masterfrom
sion-111:luci-mod-network-autoneg

Conversation

@sion-111
Copy link

  • This PR is not from my main or master branch, but a separate branch
  • Each commit has a valid Signed-off-by: sion-111 <s.piotrowski91@gmail.com>
  • Each commit and PR title has a valid <package name>: title first line subject
  • Incremented any PKG_VERSION in the Makefile (not applicable)
  • Tested on: Banana Pi BPI-R4, OpenWrt 23.05.x, LuCI (browser: Chromium)
  • Mention the original code author for feedback
  • Screenshot or mp4 of changes
  • Closes:
  • Depends on:

Description

This change adds Auto negotiation and Duplex options to device settings
in LuCI network configuration.

Leaving the value empty keeps the default kernel behavior.

Tested on Banana Pi BPI-R4.

o.datatype = 'uinteger';


o = this.replaceOption(s, 'devgeneral', form.ListValue, 'autoneg', _('Auto negotiation'));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documentation sayes that this is a string. However, the option is actually a Boolean and therefore a flag in Luci.
If the option is not set, 1 is assumed, and should not be saved in the configuration. As this is the standard for autneg and duplex nowadays.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For devs not familiar with the luci formats, this is a viable way of handling a boolean, but it's much more 'clicking' than just a Flag. Flag is preferred 👍

@github-actions

This comment has been minimized.

Add Auto negotiation and Duplex options to the device settings form.

Signed-off-by: sion-111 <s.piotrowski91@gmail.com>
@sion-111 sion-111 force-pushed the luci-mod-network-autoneg branch from 5c71cb9 to b219d5f Compare January 28, 2026 08:56
@github-actions
Copy link

Warning

Some formality checks failed.

Consider (re)reading submissions guidelines.

Failed checks

Issues marked with an ❌ are failing checks.

Commit b219d5f

  • 🔶 Author name (sion-111) seems to be a nickname or an alias
  • 🔶 Committer name (sion-111) seems to be a nickname or an alias

For more details, see the full job log.

Something broken? Consider providing feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants