libreoffice2john.py: error in encrypted 24.2+ files#5655
Merged
solardiz merged 1 commit intobleeding-jumbofrom Feb 1, 2025
unknown repository
Merged
libreoffice2john.py: error in encrypted 24.2+ files#5655solardiz merged 1 commit intobleeding-jumbofrom unknown repository
solardiz merged 1 commit intobleeding-jumbofrom
unknown repository
Conversation
exploide
reviewed
Jan 31, 2025
run/libreoffice2john.py
Outdated
Comment on lines
+53
to
+54
| for i in range(0, len(elements)): | ||
| element = elements[i] |
Contributor
There was a problem hiding this comment.
Minor stylistic comment: for loops in Python are for-each loops. So a bit simpler and more idiomatic without the need for indices would be the following.
Suggested change
| for i in range(0, len(elements)): | |
| element = elements[i] | |
| for element in elements: |
Warn that LibreOffice 24.2+ encrypted documents are not supported. See: #5652. Signed-off-by: Claudio André <dev@claudioandre.slmail.me>
solardiz
approved these changes
Feb 1, 2025
ghost
deleted the
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warn that LibreOffice 24.2+ encrypted documents are not supported.
See: #5652.