[GPU] Improve max-allocation error guidance and enable_large_allocations docs#34894
Open
Sahilbhatane wants to merge 6 commits intoopenvinotoolkit:masterfrom
Open
[GPU] Improve max-allocation error guidance and enable_large_allocations docs#34894Sahilbhatane wants to merge 6 commits intoopenvinotoolkit:masterfrom
Sahilbhatane wants to merge 6 commits intoopenvinotoolkit:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Improves Intel GPU plugin user-facing guidance around failures caused by a single allocation exceeding the device’s maximum allocatable buffer size, and clarifies the behavior of the enable_large_allocations option/property in internal and public docs.
Changes:
- Update the max-allocation assertion message to fix formatting and point users to
GPU_ENABLE_LARGE_ALLOCATIONS. - Align the internal option description for
ov::intel_gpu::hint::enable_large_allocationswith the real check (device max allocation size rather than “>4GB”). - Clarify the public property documentation to mention bypassing the max-allocation-size check and its usefulness when exceeding
CL_DEVICE_MAX_MEM_ALLOC_SIZE.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/plugins/intel_gpu/src/runtime/engine.cpp |
Improves the assertion text for “single allocation exceeds device max alloc size” and adds a workaround hint. |
src/plugins/intel_gpu/include/intel_gpu/runtime/options.inl |
Updates the option help text to describe the behavior more accurately than the previous “>4GB” wording. |
src/inference/include/openvino/runtime/intel_gpu/properties.hpp |
Extends the public property doxygen to document bypassing the max-alloc-size check and relates it to CL_DEVICE_MAX_MEM_ALLOC_SIZE. |
Contributor
|
build_jenkins |
Author
|
@p-durandin Re-requesting build. Updated the branch, all checks passed on previous build. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details:
engine::check_allocatable()fails with an assertion. The message had a small formatting issue (missing space before "Please") and didn’t point users to theGPU_ENABLE_LARGE_ALLOCATIONS/ov::intel_gpu::hint::enable_large_allocationsworkaround.src/plugins/intel_gpu/src/runtime/engine.cppto fix the spacing and include a clear suggestion to enableGPU_ENABLE_LARGE_ALLOCATIONSwhen applicable.src/plugins/intel_gpu/include/intel_gpu/runtime/options.inlwith the actual behavior. The check is against the device max allocation size, not just “>4GB”.src/inference/include/openvino/runtime/intel_gpu/properties.hppto clarify that enabling large allocations also bypasses the max-allocation-size check, which helps when a single buffer exceedsCL_DEVICE_MAX_MEM_ALLOC_SIZE.Tickets:
AI Assistance: