Fix string literal conditions used in OPENVINO_ASSERT#33911
Open
aobolensk wants to merge 25 commits intoopenvinotoolkit:masterfrom
Open
Fix string literal conditions used in OPENVINO_ASSERT#33911aobolensk wants to merge 25 commits intoopenvinotoolkit:masterfrom
aobolensk wants to merge 25 commits intoopenvinotoolkit:masterfrom
Conversation
github-actions
bot
added
category: Core
aobolensk
force-pushed
the
core-string-lit-assert
branch
from
0940e67 to
e47d20b
Compare
aobolensk
force-pushed
the
core-string-lit-assert
branch
2 times, most recently
from
07e770d to
d09b6a8
Compare
github-actions
bot
added
the
category: LP transformations
aobolensk
force-pushed
the
core-string-lit-assert
branch
2 times, most recently
from
5bc283a to
c522f11
Compare
aobolensk
changed the title
praasz
reviewed
Feb 2, 2026
…conditions in OPENVINO_ASSERT Add guard and update hetero/gpu code paths to use OPENVINO_THROW or explicit predicate asserts
aobolensk
force-pushed
the
core-string-lit-assert
branch
from
277aecc to
c649f8f
Compare
Lyamin-Roman
approved these changes
Feb 2, 2026
| do { \ | ||
| auto _ov_check_condition = [](const auto& v) -> void { \ | ||
| using _ov_check_t = ::std::remove_reference_t<decltype(v)>; \ | ||
| if constexpr (::std::is_array_v<_ov_check_t> && \ |
Contributor
There was a problem hiding this comment.
Does it make sense to have different error messages for different types of strings?
Contributor
Author
There was a problem hiding this comment.
Fair enough, removed
aobolensk
force-pushed
the
core-string-lit-assert
branch
from
c649f8f to
5d630a6
Compare
aobolensk
force-pushed
the
core-string-lit-assert
branch
from
0e431b4 to
1fa16fa
Compare
praasz
reviewed
Feb 23, 2026
| explicit NotImplemented(const std::string& what_arg) : ov::AssertFailure(what_arg) {} | ||
| }; | ||
|
|
||
| namespace detail { |
Contributor
There was a problem hiding this comment.
Remove this section and hide inside the macro. There should be more public functions to handle OV exceptions for internal checks
| auto dest_type_i64 = std::pair<std::string, detail::AttrAny>({"destination_type", "i64"}); | ||
| auto dest_type_f32 = std::pair<std::string, detail::AttrAny>({"destination_type", "f32"}); | ||
| auto dest_type_f16 = std::pair<std::string, detail::AttrAny>({"destination_type", "f16"}); | ||
| auto dest_type_i64 = std::pair<std::string, gen_pattern::detail::AttrAny>({"destination_type", "i64"}); |
Contributor
There was a problem hiding this comment.
This should not be required because of exception changes.
aobolensk
changed the title
Contributor
Author
|
The solution is cumbersome if we use C++17 only. There is no robust way to implement in a proper way without triggering many other compiler warnings. Decided to postpone proper solution until C++20 enabling. For now, fixed all incorrect assertions only without changes to |
github-actions
bot
removed
category: Core
praasz
reviewed
Mar 20, 2026
Contributor
|
build_jenkins |
praasz
approved these changes
Mar 20, 2026
Contributor
|
build_jenkins |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details:
Fix "always true" assertions when string literal is passed as an assert argument.
Tickets: