[OV][ITT] Enhance ITT MACROS to accept metadata for ID propagation#33311
[OV][ITT] Enhance ITT MACROS to accept metadata for ID propagation#33311tovinkere wants to merge 0 commit intoopenvinotoolkit:masterfrom
Conversation
| namespace domains { | ||
| OV_ITT_DOMAIN(OV, "ov"); | ||
| OV_ITT_DOMAIN(ReadTime, "ov::ReadTime"); | ||
| OV_ITT_DOMAIN(LoadTime, "ov::LoadTime"); |
There was a problem hiding this comment.
@aobolensk
It looks like change of the regions names was API break should be deprecated first as this is public interface.
Could be old domains restored and both used?
src/inference/dev_api/openvino/runtime/iasync_infer_request.hpp
Outdated
Show resolved
Hide resolved
| #include "openvino/runtime/tensor.hpp" | ||
| #include "openvino/runtime/threading/itask_executor.hpp" | ||
|
|
||
| #if defined(ENABLE_PROFILING_ITT_FULL) || defined(ENABLE_PROFILING_ITT_BASE) |
There was a problem hiding this comment.
For future improvement it could be hidden in current or some additional util macro for ITT.
This macro could inject members into class, struct and macros like OV_ITT_SCOPED_REGION_BASE could assume the members are inside classes. It will help if such class instrumentation is required for others and this code will be not repeated and hidden from main class functionality.
| namespace domains { | ||
| OV_ITT_DOMAIN(Plugin) | ||
| OV_ITT_DOMAIN(PluginLoadTime) | ||
| // Domain to define Inference phase tasks |
There was a problem hiding this comment.
It can be done later but for this file we should set reference to guide how the domains can be modified/added/removed etc.
|
build_jenkins |
1 similar comment
|
build_jenkins |
9a1af2f to
0d96356
Compare
#Feature enhancement - Part 1
This PR is the first of a series of PRs to standardize the ITT markers in OpenVINO that will be enabled by default through host-side instrumentation.
Summary of the current PR (PR#1)
Details:
For some plugins that use pipeline execution during asynchronous evaluation, the inference is initiated on one thread, the pipeline execution begins on another thread and is completed on a different thread. In order to get the full inference time, including host side timestamps, the stages of execution that belong to the same inference pass MUST:
@aobolensk Please review as this is an extension of your work with regions.