Skip to content

[Snippets] Fix exec_num precision issues in LinearIR expression ordering #31975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
v-Golubev merged 2 commits into from
Sep 4, 2025
Merged

[Snippets] Fix exec_num precision issues in LinearIR expression ordering #31975

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4fc75b7
[Snippets] Fix exec_num precision issues in LinearIR expression ordering
aobolensk Sep 4, 2025
662856c
Fix comparison
aobolensk Sep 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions src/common/snippets/src/lowered/linear_ir.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@

#include <algorithm>
#include <cassert>
#include <cmath>
#include <cstddef>
#include <cstdint>
#include <cstdlib>
Expand Down Expand Up @@ -578,21 +579,19 @@ double LinearIR::get_inserted_expr_exec_num(constExprIt insertion_pos) const {
if (right_pos->get()->get_exec_num() == -1 * std::numeric_limits<double>::max()) {
enumerate_expressions();
}
return right_pos->get()->get_exec_num() - 1;
return std::nextafter(right_pos->get()->get_exec_num(), -std::numeric_limits<double>::infinity());
}
if (right_pos == cend()) { // On the list end
if (left_pos->get()->get_exec_num() == std::numeric_limits<double>::max()) {
enumerate_expressions();
}
return left_pos->get()->get_exec_num() + 1;
return std::nextafter(left_pos->get()->get_exec_num(), std::numeric_limits<double>::infinity());
} // In the list middle
left_order = left_pos->get()->get_exec_num();
right_order = right_pos->get()->get_exec_num();
OPENVINO_ASSERT(right_order > left_order, "Incorrect expression enumeration!");

// sync point to enumerate expressions
// 10 * eps - is to avoid meaningless result after (right_order + left_order) / 2 below
if (std::abs(1 - left_order / right_order) <= 10 * std::numeric_limits<double>::epsilon()) {
if (std::nextafter(left_order, right_order) >= right_order) {
enumerate_expressions();
left_order = left_pos->get()->get_exec_num();
right_order = right_pos->get()->get_exec_num();
Expand Down
Loading