[Snippets] LoopManager: error-prone code is removed#31952
Merged
v-Golubev merged 7 commits intoopenvinotoolkit:masterfrom Sep 4, 2025
Merged
[Snippets] LoopManager: error-prone code is removed#31952v-Golubev merged 7 commits intoopenvinotoolkit:masterfrom
v-Golubev merged 7 commits intoopenvinotoolkit:masterfrom
Conversation
Contributor
Author
|
@aobolensk Could you please take a look? Thanks in advance |
aobolensk
reviewed
Sep 3, 2025
aobolensk
approved these changes
Sep 4, 2025
Merged
via the queue into
openvinotoolkit:master
with commit Sep 4, 2025
cf73a96
220 of 222 checks passed
praasz
pushed a commit
to praasz/openvino
that referenced
this pull request
Sep 8, 2025
…31952) ### Details: - *Removed `LoopInfo` constructor with vector of `ExpressionPort` as entries/exits and the corresponding `mark_loop` helper in `LoopManager`, since it is unsafe (it set `dim_idx=0` for all ports)* - *Removed `dim_idx` from `mark_loop` helper with `LoopPort` entries and exits, since LoopPort already contains `dim_idx` calue* - *`LoopPort::create`: removed default value for `dim_idx`* As a result of error-prone code with non-obvious logic removal, now it's impossible to forget specifying `dim_idx` for some specific loop port (otherwise, compilation fails) during loops creation, and there are no ways to create loop from expression ports without loop ports creation. ### Tickets: - *prerequisite for CVS-172631*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details:
LoopInfoconstructor with vector ofExpressionPortas entries/exits and the correspondingmark_loophelper inLoopManager, since it is unsafe (it setdim_idx=0for all ports)dim_idxfrommark_loophelper withLoopPortentries and exits, since LoopPort already containsdim_idxcalueLoopPort::create: removed default value fordim_idxAs a result of error-prone code with non-obvious logic removal, now it's impossible to forget specifying
dim_idxfor some specific loop port (otherwise, compilation fails) during loops creation, and there are no ways to create loop from expression ports without loop ports creation.Tickets: