[spec][ref][cpu][gpu]: Added OneHot v16 by pkowalc1 · Pull Request #31901 · openvinotoolkit/openvino

pkowalc1 · 2025-08-28T13:54:00Z

Added OneHot v16 operator with with new attribute: negative_indices_mode, with two modes:

ignore_negative, which behaves exactly as the OneHot-1
normalize, which is aimed to support onnx.OneHot-11 op.

Added support of this new op to reference, CPU and GPU implementations, ONNX fronteds, etc. Added new tests/fixed existing.

Tickets:

CVS-73538

…ests.

…owalc1/openvino into fix_one_hot_negative_indicies

mitruska

The code for new operation LGTM. Approved conditionally if the ConvertOneHot16To1 transformation will be fixed and tested in a following PR (or removed from this one). The place and need of the downgrade transformation call should be consulted with NPU plugin, as GPU and CPU is updated.
cc: @openvinotoolkit/openvino-npu-maintainers

src/common/transformations/src/transformations/op_conversions/convert_one_hot_v16_to_v1.cpp

mitruska · 2025-09-09T06:43:49Z

src/common/transformations/src/transformations/op_conversions/convert_one_hot_v16_to_v1.cpp

+#include "openvino/op/one_hot.hpp"
+#include "openvino/pass/pattern/op/wrap_type.hpp"
+
+ov::pass::ConvertOneHot16To1::ConvertOneHot16To1() {


This ConvertOneHot16To1 transformation seems to be not tested and never called, (or registered in common transformations like):

openvino/src/common/transformations/src/transformations/common_optimizations/common_optimizations.cpp

Lines 223 to 224 in 417dd77

REGISTER_PASS(manager, ConvertMaxPool14ToMaxPool8)

REGISTER_PASS(manager, ConvertMaxPool8ToMaxPool1)

But as GPU and CPU plugin is already updated it is likely needed for NPU only.

OK, I have removed that transformation and I will add it in following pr.

Lyamin-Roman

GPU part LGTM

praasz

OK for core part

praasz · 2025-09-12T08:20:00Z

src/core/include/openvino/op/util/one_hot_base.hpp

+private:
+    friend void inline resolve_axis(OneHotBase* op);


In general friends has been removed in ops (looks like missed for this op). It can be removed also as we got get_axis and it can be used in shape inference functions.

src/core/shape_inference/include/one_hot_shape_inference.hpp

praasz · 2025-09-12T08:21:54Z

src/core/src/op/util/one_hot_base.cpp

+namespace ov {
+namespace op {
+namespace util {


As this is new file

Suggested change

namespace ov {

namespace op {

namespace util {

namespace ov::op::util {

praasz · 2025-09-12T08:22:39Z

src/core/include/openvino/op/util/one_hot_base.hpp

+namespace ov {
+namespace op {
+namespace util {


AS new file added:

Suggested change

namespace ov {

namespace op {

namespace util {

namespace ov::op::util {

src/common/transformations/src/transformations/op_conversions/convert_one_hot_v16_to_v1.cpp

praasz · 2025-09-12T08:24:59Z

src/core/tests/pass/constant_folding.cpp

+template <typename TOpFunc>
+void OneHotConstantFoldingGenericTest(const TOpFunc& op_func) {


Suggested change

template <typename TOpFunc>

void OneHotConstantFoldingGenericTest(const TOpFunc& op_func) {

template <typename TOneHot>

void OneHotConstantFoldingGenericTest(const TOneHot& one_hot_op) {

?

praasz · 2025-09-12T08:27:02Z

src/plugins/intel_cpu/src/nodes/one_hot.cpp

+        if (none_of(op->get_type_info(),
+                    op::v1::OneHot::get_type_info_static(),
+                    op::v16::OneHot::get_type_info_static())) {


Maybe check if base class is one hot?

…convert_one_hot_v16_to_v1.cpp Co-authored-by: Katarzyna Mitrus <katarzyna.mitrus@intel.com>

Co-authored-by: Pawel Raasz <pawel.raasz@intel.com>

…convert_one_hot_v16_to_v1.cpp Co-authored-by: Pawel Raasz <pawel.raasz@intel.com>

pkowalc1 added 18 commits July 31, 2025 09:40

[ref][one_hot]: Added support for negative indicies. Fixed tests.

597c1e3

[ref][one_hot]: Fixed code style.

04e718e

[onnx]: Disabled onehot test.

972560b

[gpu][one_hot]: Added support for negative indicies, added unittests.

7304114

[cpu]: [one_hot]: Added support for negative indicies and and added t…

2f937d5

…ests.

[doc]:[one_hot]: Added info about supporting negative indicies.

deb076b

Merge branch 'master' into fix_one_hot_negative_indicies

5e61894

[TEMP][CI]: Add printing input to failing tests.

0ea1888

[ref]: Added NegativeIndicesMode to OneHot. Fixed ref and onnx tests.

b76c367

[onnx]: Fixed doc check.

33459d7

[one_hot]: Fixed code style.

c0c8d45

[cpu][onehot]: Added support for oh mode. Fixed tests.

2d6e42c

[gpu][one_hot]: Added support for indicies mode with tests.

f8ce920

Fixed clang-format.

fd4c4d8

Merge branch 'master' into fix_one_hot_negative_indicies

77fffc3

[doc][onehot]: Added description of negative indices mode.

889ed07

Merge branch 'fix_one_hot_negative_indicies' of https://github.com/pk…

3ff9d3d

…owalc1/openvino into fix_one_hot_negative_indicies

[gpu][cpu][ref]: Added OneHot v16 WIP

42580f2

pkowalc1 added the WIP work in progress label Aug 28, 2025

pkowalc1 requested review from a team as code owners August 28, 2025 13:54

pkowalc1 requested review from kblaszczak-intel and removed request for a team August 28, 2025 13:54

github-actions bot added category: Core OpenVINO Core (aka ngraph) category: GPU OpenVINO GPU plugin labels Aug 28, 2025

pkowalc1 added 8 commits September 3, 2025 09:39

[one_hot]: Fixed cput shape inference tests.

84f6b64

[one_hot]: Fixed tests.

f523520

[one_hot]: Added functional tests

29f42a4

[OneHot]: added new spec.

e2e0a0a

[OneHotv1]: Restored spec.

2c921aa

[OneHot1]: Restored spec.

ad1654e

[OneHot1]: restored.

d8c1432

[onehot]: Added transformation from v16 to v1

6bbe914

pkowalc1 requested a review from a team as a code owner September 4, 2025 07:56

pkowalc1 requested review from CuriousPanCake and removed request for a team September 4, 2025 07:56

github-actions bot added the category: transformations OpenVINO Runtime library - Transformations label Sep 4, 2025

[onehot]: Fxied code style

e26471a

pkowalc1 changed the title ~~[WIP][spec][ref][cpu][gpu]: Added OneHot v16~~ [spec][ref][cpu][gpu]: Added OneHot v16 Sep 5, 2025

pkowalc1 removed the WIP work in progress label Sep 5, 2025

mitruska approved these changes Sep 9, 2025

View reviewed changes

Lyamin-Roman approved these changes Sep 9, 2025

View reviewed changes

praasz approved these changes Sep 12, 2025

View reviewed changes

praasz added this to the 2025.4 milestone Sep 12, 2025

pkowalc1 and others added 5 commits September 15, 2025 10:02

Update src/common/transformations/src/transformations/op_conversions/…

e99ce09

…convert_one_hot_v16_to_v1.cpp Co-authored-by: Katarzyna Mitrus <katarzyna.mitrus@intel.com>

Update src/core/shape_inference/include/one_hot_shape_inference.hpp

1570297

Co-authored-by: Pawel Raasz <pawel.raasz@intel.com>

Update src/common/transformations/src/transformations/op_conversions/…

90c900d

…convert_one_hot_v16_to_v1.cpp Co-authored-by: Pawel Raasz <pawel.raasz@intel.com>

[onehot]: Removed transformation v16 to v1.

dd498d8

[one_hote]: Removed transformation v16 to v1.

29908e4

github-actions bot removed the category: transformations OpenVINO Runtime library - Transformations label Sep 15, 2025

pkowalc1 added this pull request to the merge queue Sep 16, 2025

Merged via the queue into openvinotoolkit:master with commit c3ec20d Sep 16, 2025
221 of 223 checks passed

pkowalc1 deleted the fix_one_hot_negative_indicies_with_new_op_ver branch September 16, 2025 11:09

mitruska mentioned this pull request Sep 17, 2025

[onehot]: Added OneHot v16 to v1 transformation with unittests. #32095

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[spec][ref][cpu][gpu]: Added OneHot v16#31901

[spec][ref][cpu][gpu]: Added OneHot v16#31901
pkowalc1 merged 48 commits intoopenvinotoolkit:masterfrom
pkowalc1:fix_one_hot_negative_indicies_with_new_op_ver

pkowalc1 commented Aug 28, 2025 •

edited

Loading

Uh oh!

mitruska left a comment •

edited

Loading

Uh oh!

Uh oh!

mitruska Sep 9, 2025

Uh oh!

pkowalc1 Sep 15, 2025

Uh oh!

Lyamin-Roman left a comment

Uh oh!

praasz left a comment

Uh oh!

praasz Sep 12, 2025

Uh oh!

Uh oh!

praasz Sep 12, 2025

Uh oh!

praasz Sep 12, 2025

Uh oh!

Uh oh!

praasz Sep 12, 2025

Uh oh!

praasz Sep 12, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

	REGISTER_PASS(manager, ConvertMaxPool14ToMaxPool8)
	REGISTER_PASS(manager, ConvertMaxPool8ToMaxPool1)

		template <typename TOpFunc>
		void OneHotConstantFoldingGenericTest(const TOpFunc& op_func) {

Conversation

pkowalc1 commented Aug 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Tickets:

Uh oh!

mitruska left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mitruska Sep 9, 2025

Choose a reason for hiding this comment

Uh oh!

pkowalc1 Sep 15, 2025

Choose a reason for hiding this comment

Uh oh!

Lyamin-Roman left a comment

Choose a reason for hiding this comment

Uh oh!

praasz left a comment

Choose a reason for hiding this comment

Uh oh!

praasz Sep 12, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

praasz Sep 12, 2025

Choose a reason for hiding this comment

Uh oh!

praasz Sep 12, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

praasz Sep 12, 2025

Choose a reason for hiding this comment

Uh oh!

praasz Sep 12, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

pkowalc1 commented Aug 28, 2025 •

edited

Loading

mitruska left a comment •

edited

Loading