Open
Conversation
|
Can one of the admins verify this patch? |
| ucc_pt_rocm_init(); | ||
| try { | ||
| comm = new ucc_pt_comm(pt_config.comm); | ||
| comm = new ucc_pt_comm(pt_config.comm,pt_config.bench); |
wfaderhold21
approved these changes
Jan 31, 2025
Collaborator
wfaderhold21
left a comment
wfaderhold21
left a comment
There was a problem hiding this comment.
Looks good. Minor comments.
| ucc_pt_coll_alltoall::ucc_pt_coll_alltoall(ucc_datatype_t dt, | ||
| ucc_memory_type mt, bool is_inplace, | ||
| bool is_persistent, | ||
| bool is_persistent,bool is_onesided, |
| coll_args.mask |= UCC_COLL_ARGS_FIELD_FLAGS; | ||
| coll_args.flags |= UCC_COLL_ARGS_FLAG_PERSISTENT; | ||
| } | ||
| if(is_onesided){ |
Collaborator
There was a problem hiding this comment.
spacing / formatting
| free_dst, st); | ||
| args.src.info.buffer = src_header->addr; | ||
| } | ||
| if(UCC_IS_ONESIDED(args)){ |
| if(UCC_IS_ONESIDED(args)){ | ||
| args.src.info.buffer = comm->get_global_buffer(0); | ||
| args.dst.info.buffer = comm->get_global_buffer(1); | ||
| args.global_work_buffer = comm->get_global_buffer(2); |
| args.src.info.buffer = src_header->addr; | ||
| } | ||
| if(UCC_IS_ONESIDED(args)){ | ||
| args.src.info.buffer = comm->get_global_buffer(0); |
Collaborator
There was a problem hiding this comment.
Maybe instead of 0, 1, or 2, define a name for them like MEM_SEND_SEGMENT ? Then can use like:
args.src.info.buffer = comm->get_global_buffer(MEM_SEND_SEGMENT);
| { | ||
| onesided_buffers[i] = NULL; | ||
| } | ||
|
|
| team_params.oob = bootstrap->get_team_oob(); | ||
| team_params.ep = bootstrap->get_rank(); | ||
| team_params.ep_range = UCC_COLLECTIVE_EP_RANGE_CONTIG; | ||
| if(bcfg.onesided){ |
| void set_gpu_device(); | ||
| public: | ||
| ucc_pt_comm(ucc_pt_comm_config config); | ||
| ucc_pt_comm(ucc_pt_comm_config config,ucc_pt_benchmark_config ben_config); |
| throw std::out_of_range("Index out range"); | ||
| } | ||
| return onesided_buffers[index]; | ||
|
|
| ucc_status_t st; | ||
|
|
||
| while ((c = getopt(argc, argv, "c:b:e:d:m:n:w:o:N:r:S:iphFT")) != -1) { | ||
| while ((c = getopt(argc, argv, "c:b:e:d:m:n:w:o:N:r:S:iphFTJ")) != -1) { |
Collaborator
There was a problem hiding this comment.
Should we use O to be for onesided?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add onesided collective in perf to test ucp alltoall_onesided alg
Why ?
Direct testing will appear the error of TL_UCP ERROR global work buffer not provided nor associated with team
How ?
When test onesided alltoall ,add -J