This repository was archived by the owner on Feb 20, 2026. It is now read-only.
VIDCS-3351: Add sample leveraging foreground services#522
Merged
goncalocostamendes merged 11 commits intomainfrom Feb 11, 2025
Merged
VIDCS-3351: Add sample leveraging foreground services#522goncalocostamendes merged 11 commits intomainfrom
goncalocostamendes merged 11 commits intomainfrom
Conversation
juliobecerragomez
approved these changes
Feb 10, 2025
juliobecerragomez
left a comment
juliobecerragomez
left a comment
There was a problem hiding this comment.
LGTM! Just left a few typos.
Contributor
joliveraortega
left a comment
joliveraortega
left a comment
There was a problem hiding this comment.
Thanks for this contribution. Looking good. Left some comments. Please, have a look.
.github/workflows/build-basic-video-chat-with_foregroundservices-java.yml
Outdated
Show resolved
Hide resolved
Basic-Video-Chat-With-ForegroundServices-Java/gradle/wrapper/gradle-wrapper.properties
Outdated
Show resolved
Hide resolved
…es-java.yml Co-authored-by: Jose Olivera Ortega <joseantonio.oliveraortega@vonage.com>
…amples into VIDCS-3351
joliveraortega
approved these changes
Feb 11, 2025
Contributor
joliveraortega
left a comment
joliveraortega
left a comment
There was a problem hiding this comment.
LGTM, r=me.
I would add support for a matrix in a single workflow file and remove all https://github.com/opentok/opentok-android-sdk-samples/tree/main/.github/workflows/build-* workflows files.
Contributor
Author
This PR is already very extense. I will create a new one |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, only foreground service being used is to keep microphone capturing when the app moves to background.