Merged
Conversation
om array commands: --mapping --host --target om <kind> config update: --set om <kind> config set: --kw om <kind> create: --env om <datastore> remove: --key om <datastore> key remove: --name Example: # bin/om cvi1 config update --set env.a=item1,item2 committed # om cvi1 config get --kw env.a item1,item2
Those caps will all begin with "node.x.path" (different from om 2.1 which used node.x.<basename>.path caps). Add GetPath and MakePath functions to ease usage.
* Use the capabilities to cache showmount and exportfs paths * Fix the showmount output parser
Fix the build error.
No longer need to use run_args to set sysctls.
panic: interface conversion: interface {} is int, not string
goroutine 100 [running]:
github.com/opensvc/om3/v3/core/xconfig.(*T).GetStringStrict(...)
/tools/tmp/debbuild/u2404/opensvc-3.0.0~rc12.1.2.g8f09dfb53+pr1013+ubuntu24.04/core/xconfig/main.go:389
github.com/opensvc/om3/v3/core/xconfig.(*T).GetString(0x0?, {{0xc0002a1860?, 0x0?}, {0x23bc035?, 0x0?}})
/tools/tmp/debbuild/u2404/opensvc-3.0.0~rc12.1.2.g8f09dfb53+pr1013+ubuntu24.04/core/xconfig/main.go:373 +0x5e
github.com/opensvc/om3/v3/core/pool.(*T).GetString(0xc000054340, {0x23bc035, 0x9})
/tools/tmp/debbuild/u2404/opensvc-3.0.0~rc12.1.2.g8f09dfb53+pr1013+ubuntu24.04/core/pool/main.go:278 +0x7c
github.com/opensvc/om3/v3/drivers/pooldrbd.T.maxPeers(...)
/tools/tmp/debbuild/u2404/opensvc-3.0.0~rc12.1.2.g8f09dfb53+pr1013+ubuntu24.04/drivers/pooldrbd/main.go:68
github.com/opensvc/om3/v3/drivers/pooldrbd.(*T).commonDrbdKeywords(0xc0006f5a40, {0x23b5c8e, 0x6})
/tools/tmp/debbuild/u2404/opensvc-3.0.0~rc12.1.2.g8f09dfb53+pr1013+ubuntu24.04/drivers/pooldrbd/main.go:253 +0x73
github.com/opensvc/om3/v3/drivers/pooldrbd.(*T).blkTranslateZpool(0xc0006f5a40, {0xc000905a80, 0x1e}, 0x15?, 0x23?)
/tools/tmp/debbuild/u2404/opensvc-3.0.0~rc12.1.2.g8f09dfb53+pr1013+ubuntu24.04/drivers/pooldrbd/main.go:248 +0x3df
github.com/opensvc/om3/v3/drivers/pooldrbd.(*T).commonTranslate(0xc0006f5a40, {0xc000905a80, 0x1e}, 0x20000000, 0x1)
/tools/tmp/debbuild/u2404/opensvc-3.0.0~rc12.1.2.g8f09dfb53+pr1013+ubuntu24.04/drivers/pooldrbd/main.go:272 +0xe7
github.com/opensvc/om3/v3/drivers/pooldrbd.(*T).Translate(0xc0006f5a40, {0xc000905a80, 0x1e}, 0x16a15a3?, 0x1)
Use the `name` keyword instead of `dev`.
Instead of the too large FilePerm (0777). This file is replicated to secondary nodes via POST /node/.../drbd/config which already uses 0644.
cvaroqui
changed the title
The binary size 'i' unit suffix is not accepted by "zvol create". Strip it.
Use "/dev/zvol/<poolname>/<volname>" instead of "/dev/<poolname>/<volname>". The new devpath scheme is available since 2017 (zfs 0.8.0), and the old one is no longer supported.
Use a 1234 port instead of a string 1.2.3.4.
A lot of query commands were not logged at all, so when one exits with a bad code, we can't know which one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.