fix(ci_gen_kustomize_values): add MTU to uni07eta net-attach-def JSON#3864
Draft
fyanac wants to merge 1 commit intoopenstack-k8s-operators:mainfrom
Draft
fix(ci_gen_kustomize_values): add MTU to uni07eta net-attach-def JSON#3864fyanac wants to merge 1 commit intoopenstack-k8s-operators:mainfrom
fyanac wants to merge 1 commit intoopenstack-k8s-operators:mainfrom
Conversation
The uni07eta network-values template already emitted mtu on each network
YAML block but the embedded Multus net-attach-def JSON omitted it, so
ctlplane and other NADs ignored cifmw_networking_definition.mtu (e.g.
jumbo for ospbr / ctlplane).
Include "mtu": {{ network.mtu | default(1500) }} in the ctlplane,
octavia, ironic, and generic macvlan net-attach-def.
Assisted-By: Cursor-composer-2-fast
Contributor
|
Skipping CI for Draft Pull Request. |
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The uni07eta network-values template already emitted mtu on each network YAML block but the embedded Multus net-attach-def JSON omitted it, so ctlplane and other NADs ignored cifmw_networking_definition.mtu (e.g. jumbo for ospbr / ctlplane).
Include "mtu": {{ network.mtu | default(1500) }} in the ctlplane, octavia, ironic, and generic macvlan net-attach-def.
Assisted-By: Cursor-composer-2-fast