Skip to content

[release-v1.17] Add missing backports#1674

Merged
openshift-merge-bot[bot] merged 7 commits intoopenshift-knative:release-v1.17from
creydr:missing-backports-v1.17
Sep 30, 2025
Merged

[release-v1.17] Add missing backports#1674
openshift-merge-bot[bot] merged 7 commits intoopenshift-knative:release-v1.17from
creydr:missing-backports-v1.17

Conversation

knative-prow-robot and others added 6 commits September 29, 2025 16:53
…ed endpoint informer (knative#8421)

* Reduce mt-broker-controller memory usage with namespaced endpoint informer

Currently, the mt-broker-controller is using a cluster-wide endpoints
informer but it actually only uses endpoints in the "SYSTEM_NAMESPACE".

Using the namespaced informer factory ensures that the watcher
is only watching endpoints in the `knative-eventing` (also known as
`SYSTEM_NAMESPACE`) namespace.

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

* Start informer

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

---------

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Co-authored-by: Pierangelo Di Pilato <pierdipi@redhat.com>
…consistent (knative#8453)

Scheduler: Resync reserved periodically to keep state consistent

Add resyncReserved removes deleted vPods from reserved to keep the
state consistent when leadership changes (Promote / Demote).

`initReserved` is not enough since the vPod lister can be stale.

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Co-authored-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Scheduler: log expected vreplicas by vpod

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Co-authored-by: Pierangelo Di Pilato <pierdipi@redhat.com>
…s PodSpec (knative#8560)

Compare the entire PodTemplateSpec, instead of just its PodSpec

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
Co-authored-by: Matthias Wessendorf <mwessend@redhat.com>
* dizzy: Remove hard-coded knative-eventing namespace and replace with system.Namespace() and touch test to get that properly injected

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* broom: Remove yet another hard-coded instance of knative-eventing

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

---------

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
Co-authored-by: Matthias Wessendorf <mwessend@redhat.com>
…sts (knative#8504)

* Guard reserved access with lock in tests

* Create vpods in test

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

---------

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Co-authored-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@openshift-ci openshift-ci bot requested a review from aliok September 29, 2025 15:06
Copy link
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

/approve

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 88f32ee and 2 for PR HEAD 18c7c97 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD a517782 and 1 for PR HEAD 18c7c97 in total

@openshift-ci openshift-ci bot removed the lgtm label Sep 30, 2025
@dsimansk
Copy link

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Sep 30, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, dsimansk, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 934c456 into openshift-knative:release-v1.17 Sep 30, 2025
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants