Skip to content

Fix nil pointer dereference in doesLeaseContainPortGroup#54

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift-eng:mainfrom
jcpowermac:fix-nil-deref-doesLeaseContainPortGroup
Feb 23, 2026
Merged

Fix nil pointer dereference in doesLeaseContainPortGroup#54
openshift-merge-bot[bot] merged 1 commit intoopenshift-eng:mainfrom
jcpowermac:fix-nil-deref-doesLeaseContainPortGroup

Conversation

@jcpowermac
Copy link
Copy Markdown
Contributor

When a lease has an owner reference to a network that isn't part of the current pool, the poolNetworks map lookup returns nil and the subsequent field access panics. Use a safe two-value map lookup and skip missing entries instead. Add unit tests covering all branches.

When a lease has an owner reference to a network that isn't part of the
current pool, the poolNetworks map lookup returns nil and the subsequent
field access panics. Use a safe two-value map lookup and skip missing
entries instead. Add unit tests covering all branches.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@openshift-ci openshift-ci bot requested review from mtulio and rvanderp3 February 23, 2026 20:24
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 23, 2026
@vr4manta
Copy link
Copy Markdown
Contributor

/assign @vr4manta

@vr4manta
Copy link
Copy Markdown
Contributor

/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 23, 2026
@vr4manta
Copy link
Copy Markdown
Contributor

/override unit

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Feb 23, 2026

@vr4manta: Overrode contexts on behalf of vr4manta: unit

Details

In response to this:

/override unit

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Feb 23, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcpowermac, vr4manta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [jcpowermac,vr4manta]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jcpowermac
Copy link
Copy Markdown
Contributor Author

/override unit

1 similar comment
@jcpowermac
Copy link
Copy Markdown
Contributor Author

/override unit

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Feb 23, 2026

@jcpowermac: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • unit

Only the following failed contexts/checkruns were expected:

  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

Details

In response to this:

/override unit

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Feb 23, 2026

@jcpowermac: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • unit

Only the following failed contexts/checkruns were expected:

  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

Details

In response to this:

/override unit

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 84d2010 into openshift-eng:main Feb 23, 2026
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants