Skip to content

SPLAT-2557: Added taint, toleration, and pool selector support#53

Merged
openshift-merge-bot[bot] merged 10 commits intoopenshift-eng:mainfrom
vr4manta:SPLAT-2557
Feb 13, 2026
Merged

SPLAT-2557: Added taint, toleration, and pool selector support#53
openshift-merge-bot[bot] merged 10 commits intoopenshift-eng:mainfrom
vr4manta:SPLAT-2557

Conversation

@vr4manta
Copy link
Copy Markdown
Contributor

@vr4manta vr4manta commented Jan 30, 2026

SPLAT-2557

Changes

  • Added pool selector
  • Added taint / toleration support
  • Added multi pool request from single lease using new pools field
  • Added unit tests and fixed existing

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 30, 2026
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jan 30, 2026

@vr4manta: This pull request references SPLAT-2557 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set.

Details

In response to this:

SPLAT-2557

Changes

  • Added pool selector
  • Added taint / toleration support
  • Added unit tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from jcpowermac and mtulio January 30, 2026 18:47
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 30, 2026
@vr4manta
Copy link
Copy Markdown
Contributor Author

/hold
Still working on one missing part for multiple pool request for scenarios such as multi vcenter / multi fd w/o needing to specify all the pools needed.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 30, 2026
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Feb 11, 2026

@vr4manta: This pull request references SPLAT-2557 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set.

Details

In response to this:

SPLAT-2557

Changes

  • Added pool selector
  • Added taint / toleration support
  • Added multi pool request from single lease using new pools field
  • Added unit tests and fixed existing

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 12, 2026
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 13, 2026
@vr4manta
Copy link
Copy Markdown
Contributor Author

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 13, 2026
@jcpowermac
Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 13, 2026
@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Feb 13, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcpowermac, vr4manta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [jcpowermac,vr4manta]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jcpowermac
Copy link
Copy Markdown
Contributor

/override unit

@jcpowermac
Copy link
Copy Markdown
Contributor

/override ci/prow/lint

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Feb 13, 2026

@jcpowermac: Overrode contexts on behalf of jcpowermac: unit

Details

In response to this:

/override unit

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Feb 13, 2026

@jcpowermac: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • ci/prow/lint

Only the following failed contexts/checkruns were expected:

  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

Details

In response to this:

/override ci/prow/lint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit b609333 into openshift-eng:main Feb 13, 2026
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants