Bump golang.org/x/crypto from 0.48.0 to 0.49.0#68
Bump golang.org/x/crypto from 0.48.0 to 0.49.0#68dependabot[bot] wants to merge 1 commit intomainfrom
Conversation
Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.48.0 to 0.49.0. - [Commits](golang/crypto@v0.48.0...v0.49.0) --- updated-dependencies: - dependency-name: golang.org/x/crypto dependency-version: 0.49.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dependabot[bot] The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
WalkthroughUpdates six indirect Go module dependencies to newer patch and minor versions: golang.org/x/crypto, golang.org/x/net, golang.org/x/sync, golang.org/x/sys, golang.org/x/term, and golang.org/x/text. No direct dependencies or public APIs are affected. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes 🚥 Pre-merge checks | ✅ 6 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (6 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@go.mod`:
- Line 17: go.mod declares Go 1.25.0 but Dockerfile.buildroot installs "go"
without a version pin; update Dockerfile.buildroot to explicitly install Go 1.25
(or later) to match go.mod and the golang.org/x/crypto v0.49.0 dependency.
Modify the Dockerfile.buildroot installation step that currently runs "dnf
install -y git go make npm" to either install the distro package that provides
golang-1.25 (or a module name like golang-1.25 if available) or download and
install the official Go 1.25 tarball and set GOROOT/GOPATH accordingly; ensure
the change targets the Dockerfile.buildroot ADD/INSTALL step and any build
scripts that assume "go" so the container uses Go 1.25 at build time.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 77de8b9e-0ba9-4a52-bd40-a28ecbc90aca
⛔ Files ignored due to path filters (14)
go.sumis excluded by!**/*.sum,!go.sumvendor/golang.org/x/net/http2/client_priority_go126.gois excluded by!vendor/**vendor/golang.org/x/net/http2/client_priority_go127.gois excluded by!vendor/**vendor/golang.org/x/net/http2/frame.gois excluded by!vendor/**vendor/golang.org/x/net/http2/http2.gois excluded by!vendor/**vendor/golang.org/x/net/http2/server.gois excluded by!vendor/**vendor/golang.org/x/net/http2/transport.gois excluded by!vendor/**vendor/golang.org/x/net/http2/writesched_priority_rfc7540.gois excluded by!vendor/**vendor/golang.org/x/net/internal/httpsfv/httpsfv.gois excluded by!vendor/**vendor/golang.org/x/sys/plan9/syscall_plan9.gois excluded by!vendor/**vendor/golang.org/x/sys/unix/ztypes_linux.gois excluded by!vendor/**vendor/golang.org/x/sys/windows/aliases.gois excluded by!vendor/**vendor/golang.org/x/sys/windows/syscall_windows.gois excluded by!vendor/**vendor/modules.txtis excluded by!vendor/**
📒 Files selected for processing (1)
go.mod
| github.com/slack-go/slack v0.19.0 | ||
| github.com/stretchr/testify v1.11.1 | ||
| golang.org/x/crypto v0.48.0 | ||
| golang.org/x/crypto v0.49.0 |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Read-only check for Go version pins in common CI/build configs.
fd -H 'go.mod|Dockerfile|Dockerfile.*|.*\.ya?ml|Makefile' . \
| xargs -r rg -n -C2 '(^go 1\.)|(golang:1\.)|(setup-go)|(GO_VERSION)|(go-version)'Repository: openshift-eng/ship-status-dash
Length of output: 1193
🏁 Script executed:
#!/bin/bash
# Search for CI/workflow configuration more specifically
echo "=== Searching .github/workflows/ for Go version pins ==="
find .github/workflows -type f -name "*.yml" -o -name "*.yaml" 2>/dev/null | xargs -r rg -n -C2 'go.*1\.[0-9]+|golang:[0-9]+\.[0-9]+' 2>/dev/null || echo "No .github/workflows found or no matches"
echo -e "\n=== Checking for other CI configs ==="
fd -H '\.circleci|\.gitlab-ci|jenkins|\.travis\.yml|\.drone\.yml' . 2>/dev/null | head -20
echo -e "\n=== Listing all non-vendor config files at repo root ==="
find . -maxdepth 1 -type f \( -name "*.yml" -o -name "*.yaml" -o -name "Dockerfile*" -o -name "Makefile" \) 2>/dev/null | grep -v vendor
echo -e "\n=== Confirming go.mod content ==="
head -5 go.modRepository: openshift-eng/ship-status-dash
Length of output: 947
🏁 Script executed:
#!/bin/bash
# Check key config files for Go version pins
echo "=== Dockerfile.buildroot content ==="
cat ./Dockerfile.buildroot
echo -e "\n=== Makefile content (limited to key lines) ==="
head -50 ./Makefile
echo -e "\n=== .golangci.yml content ==="
cat ./.golangci.ymlRepository: openshift-eng/ship-status-dash
Length of output: 2941
Pin Go version in Dockerfile.buildroot to match go.mod requirement.
The go.mod declares Go 1.25.0 (line 3), but Dockerfile.buildroot installs Go without a version pin (dnf install -y git go make npm). UBI 9 default repositories do not provide Go 1.25—this will cause the build to fail or use an incompatible Go version. Update the Dockerfile to explicitly install Go 1.25 (or later) to align with the golang.org/x/crypto v0.49.0 dependency and the module's declared version.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@go.mod` at line 17, go.mod declares Go 1.25.0 but Dockerfile.buildroot
installs "go" without a version pin; update Dockerfile.buildroot to explicitly
install Go 1.25 (or later) to match go.mod and the golang.org/x/crypto v0.49.0
dependency. Modify the Dockerfile.buildroot installation step that currently
runs "dnf install -y git go make npm" to either install the distro package that
provides golang-1.25 (or a module name like golang-1.25 if available) or
download and install the official Go 1.25 tarball and set GOROOT/GOPATH
accordingly; ensure the change targets the Dockerfile.buildroot ADD/INSTALL step
and any build scripts that assume "go" so the container uses Go 1.25 at build
time.
Bumps golang.org/x/crypto from 0.48.0 to 0.49.0.
Commits
982eaa6go.mod: update golang.org/x dependencies159944fssh,acme: clean up tautological/impossible nil conditionsa408498acme: only require prompt if server has terms of servicecab0f71all: upgrade go directive to at least 1.25.0 [generated]2f26647x509roots/fallback: update bundleDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)Summary by CodeRabbit