NO-ISSUE: Update verbiage#3159
NO-ISSUE: Update verbiage#3159pawanpinjarkar wants to merge 1 commit intoopenshift-assisted:masterfrom
Conversation
With OCP 4.19.9, the OVE ISO size is approximately 40GB.
openshift-ci-robot
added
the
jira/valid-reference
|
@pawanpinjarkar: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: pawanpinjarkar The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
WalkthroughUpdated static UI copy in the disconnected cluster wizard review step to change the ISO size text from “approx. 35GB” to “approx. 40GB”. No functional or API changes. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
|
/cc @rawagner |
openshift-ci
bot
added
the
needs-ok-to-test
|
Hi @pawanpinjarkar. Thanks for your PR. I'm waiting for a openshift-assisted member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
openshift-ci
bot
added
the
size/XS
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
libs/ui-lib/lib/ocm/components/clusterWizard/disconnected/ReviewStep.tsx (1)
113-113: Minor copy/style nit: unit spacing.Prefer “40 GB” (with a space) for readability and consistency with common style guides.
Apply:
-<DescriptionListDescription>approx. 40GB</DescriptionListDescription> +<DescriptionListDescription>approx. 40 GB</DescriptionListDescription>
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
libs/ui-lib/lib/ocm/components/clusterWizard/disconnected/ReviewStep.tsx(1 hunks)
🔇 Additional comments (1)
libs/ui-lib/lib/ocm/components/clusterWizard/disconnected/ReviewStep.tsx (1)
113-113: LGTM: Copy update matches the PR intent.The change to “approx. 40GB” aligns with the PR description. No functional impact.
| <DescriptionListGroup> | ||
| <DescriptionListTerm>ISO size</DescriptionListTerm> | ||
| <DescriptionListDescription>approx. 35GB</DescriptionListDescription> | ||
| <DescriptionListDescription>approx. 40GB</DescriptionListDescription> |
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Avoid hardcoding a size that can drift with “latest”.
Since the URL points to “latest”, the ISO size can change by release. Consider adding “(varies by release)” or sourcing the size from a config/build-time constant to reduce future edits.
You can quickly verify the current size:
🏁 Script executed:
#!/bin/bash
URL='https://mirror.openshift.com/pub/cgw/assisted-installer-disconnected/latest/agent-ove.x86_64.iso'
bytes=$(curl -fsI "$URL" | tr -d '\r' | awk 'tolower($1)=="content-length:"{print $2}')
python - <<PY
b = int("$bytes") if "$bytes" else 0
print(f"Content-Length: {b} bytes (~{b/1024/1024/1024:.2f} GiB)")
PYLength of output: 334
🏁 Script executed:
#!/bin/bash
rg -n "mirror.openshift.com/pub/cgw" .Length of output: 218
🏁 Script executed:
#!/bin/bash
URL='https://mirror.openshift.com/pub/cgw/assisted-installer-disconnected/latest/agent-ove.x86_64.iso'
# Follow redirects and extract the final Content-Length header
bytes=$(curl -fsIL "$URL" | tr -d '\r' | awk 'tolower($1)=="content-length:"{print $2}' | tail -n1)
python - <<PY
b = int("$bytes") if "$bytes" else 0
print(f"Content-Length: {b} bytes (~{b/1024/1024/1024:.2f} GiB)")
PYLength of output: 353
Fix the ISO URL and avoid hardcoding approximate size
- In libs/ui-lib/lib/ocm/components/clusterWizard/disconnected/ReviewStep.tsx:36 the URL is missing “operator” (“agent-ove…”), causing a 404 and incorrect size. Update to:
- 'https://mirror.openshift.com/pub/cgw/assisted-installer-disconnected/latest/agent-ove.x86_64.iso'; + 'https://mirror.openshift.com/pub/cgw/assisted-installer-disconnected/latest/agent-operator.x86_64.iso';
- Once the URL is correct, either pull its size from a build-time constant or append “(varies by release)” instead of hardcoding “approx. 40 GB.”
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| <DescriptionListDescription>approx. 40GB</DescriptionListDescription> | |
| // libs/ui-lib/lib/ocm/components/clusterWizard/disconnected/ReviewStep.tsx | |
| // Around line 36, update the disconnected ISO URL: | |
| - const disconnectedIsoURL = | |
| const disconnectedIsoURL = | |
| 'https://mirror.openshift.com/pub/cgw/assisted-installer-disconnected/latest/agent-operator.x86_64.iso'; |
|
@pawanpinjarkar: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
openshift-merge-robot
added
the
needs-rebase
3 participants
With OCP 4.19.9, the OVE ISO size is approximately 40GB.
Summary by CodeRabbit