TRUNK-6678: Fix JUnit test assertions and improve disabled test documentation#6306
Open
imandeepduhan wants to merge 1 commit into
Open
TRUNK-6678: Fix JUnit test assertions and improve disabled test documentation#6306imandeepduhan wants to merge 1 commit into
imandeepduhan wants to merge 1 commit into
Conversation
|
jwnasambu
reviewed
Jul 19, 2026
| */ | ||
| @Test | ||
| @Disabled | ||
| @Disabled("Temporarily disabled because it fails when executed with other tests") |
Contributor
There was a problem hiding this comment.
Good start @imandeepduhan. The assertion order fix is correct.
Kindly the @disabled reason could be more specific "fails when executed with other tests" is close to what the existing TODO comment already says. If you know which tests cause the conflict or what the error message is including that would help whoever eventually fixes it. Not a blocker though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated JUnit test assertions to follow the correct assertEquals(expected, actual) convention and added a descriptive reason to the @disabled annotation. These changes improve test readability, follow JUnit best practices, and make disabled tests easier to understand.
JIRA TICKET : https://openmrs.atlassian.net/browse/TRUNK-6678