8356548: Use ClassFile API instead of ASM to transform classes in tests#317
8356548: Use ClassFile API instead of ASM to transform classes in tests#317rm-gh-8 wants to merge 1 commit intoopenjdk:masterfrom
Conversation
|
👋 Welcome back rm-gh-8! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
This backport pull request has now been updated with issue from the original commit. |
|
|
|
/approval request for backport of JDK-8356548: Use ClassFile API instead of ASM to transform classes in tests. This is a test fix. For parity with Oracle JDK. |
Backporting JDK-8356548: Use ClassFile API instead of ASM to transform classes in tests.
This PR migrates HotSpot tests from using ASM to the ClassFile API for bytecode transformation to avoid the ongoing maintenance burden of updating ASM for future class file formats.
For parity with Oracle JDK.
Ran related tests on linux-x64, linux-aarch64, macos-aarch64 and windows-x64:
make test TEST=test/hotspot/jtreg/compiler/calls
make test TEST=test/hotspot/jtreg/compiler/jsr292/RedefineMethodUsedByMultipleMethodHandles.java
make test TEST=test/hotspot/jtreg/runtime/MirrorFrame
make test TEST=test/hotspot/jtreg/serviceability/jvmti/RedefineClasses
make test TEST=test/hotspot/jtreg/vmTestbase/gc/g1/unloading
make test TEST=test/hotspot/jtreg/vmTestbase/nsk/jvmti/GetClassFields
Results attached:
windows-x64-specific-test.log
windows-x64-specific-2-test.log
windows-x64-specific-3-test.log
windows-x64-specific-4-test.log
windows-x64-specific-5-test.log
windows-x64-specific-6-test.log
macos-aarch64-specific-test.log
macos-aarch64-specific-2-test.log
macos-aarch64-specific-3-test.log
macos-aarch64-specific-4-test.log
macos-aarch64-specific-5-test.log
macos-aarch64-specific-6-test.log
linux-x64-specific-test.log
linux-x64-specific-2-test.log
linux-x64-specific-3-test.log
linux-x64-specific-4-test.log
linux-x64-specific-5-test.log
linux-x64-specific-6-test.log
linux-aarch64-specific-test.log
linux-aarch64-specific-2-test.log
linux-aarch64-specific-3-test.log
linux-aarch64-specific-4-test.log
linux-aarch64-specific-5-test.log
linux-aarch64-specific-6-test.log
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/317/head:pull/317$ git checkout pull/317Update a local copy of the PR:
$ git checkout pull/317$ git pull https://git.openjdk.org/jdk25u-dev.git pull/317/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 317View PR using the GUI difftool:
$ git pr show -t 317Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/317.diff
Using Webrev
Link to Webrev Comment