Skip to content

8356548: Use ClassFile API instead of ASM to transform classes in tests#317

Open
rm-gh-8 wants to merge 1 commit intoopenjdk:masterfrom
rm-gh-8:JDK-8356548-V25
Open

8356548: Use ClassFile API instead of ASM to transform classes in tests#317
rm-gh-8 wants to merge 1 commit intoopenjdk:masterfrom
rm-gh-8:JDK-8356548-V25

Conversation

@rm-gh-8
Copy link
Contributor

@rm-gh-8 rm-gh-8 commented Feb 25, 2026

Backporting JDK-8356548: Use ClassFile API instead of ASM to transform classes in tests.

This PR migrates HotSpot tests from using ASM to the ClassFile API for bytecode transformation to avoid the ongoing maintenance burden of updating ASM for future class file formats.

For parity with Oracle JDK.

Ran related tests on linux-x64, linux-aarch64, macos-aarch64 and windows-x64:

make test TEST=test/hotspot/jtreg/compiler/calls
make test TEST=test/hotspot/jtreg/compiler/jsr292/RedefineMethodUsedByMultipleMethodHandles.java
make test TEST=test/hotspot/jtreg/runtime/MirrorFrame
make test TEST=test/hotspot/jtreg/serviceability/jvmti/RedefineClasses
make test TEST=test/hotspot/jtreg/vmTestbase/gc/g1/unloading
make test TEST=test/hotspot/jtreg/vmTestbase/nsk/jvmti/GetClassFields

Results attached:

windows-x64-specific-test.log
windows-x64-specific-2-test.log
windows-x64-specific-3-test.log
windows-x64-specific-4-test.log
windows-x64-specific-5-test.log
windows-x64-specific-6-test.log
macos-aarch64-specific-test.log
macos-aarch64-specific-2-test.log
macos-aarch64-specific-3-test.log
macos-aarch64-specific-4-test.log
macos-aarch64-specific-5-test.log
macos-aarch64-specific-6-test.log
linux-x64-specific-test.log
linux-x64-specific-2-test.log
linux-x64-specific-3-test.log
linux-x64-specific-4-test.log
linux-x64-specific-5-test.log
linux-x64-specific-6-test.log
linux-aarch64-specific-test.log
linux-aarch64-specific-2-test.log
linux-aarch64-specific-3-test.log
linux-aarch64-specific-4-test.log
linux-aarch64-specific-5-test.log
linux-aarch64-specific-6-test.log


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8356548 needs maintainer approval

Issue

  • JDK-8356548: Use ClassFile API instead of ASM to transform classes in tests (Sub-task - P4 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/317/head:pull/317
$ git checkout pull/317

Update a local copy of the PR:
$ git checkout pull/317
$ git pull https://git.openjdk.org/jdk25u-dev.git pull/317/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 317

View PR using the GUI difftool:
$ git pr show -t 317

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/317.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 25, 2026

👋 Welcome back rm-gh-8! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Feb 25, 2026

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 3248aaf3c4f6784d5176e2a2c5bac0fbda47ee6b 8356548: Use ClassFile API instead of ASM to transform classes in tests Feb 25, 2026
@openjdk
Copy link

openjdk bot commented Feb 25, 2026

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Feb 25, 2026
@rm-gh-8 rm-gh-8 marked this pull request as ready for review February 26, 2026 22:45
@openjdk
Copy link

openjdk bot commented Feb 26, 2026

⚠️ @rm-gh-8 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 26, 2026
@rm-gh-8
Copy link
Contributor Author

rm-gh-8 commented Feb 26, 2026

/approval request for backport of JDK-8356548: Use ClassFile API instead of ASM to transform classes in tests.

This is a test fix.

For parity with Oracle JDK.

@openjdk
Copy link

openjdk bot commented Feb 26, 2026

@rm-gh-8
8356548: The approval request has been created successfully.

@mlbridge
Copy link

mlbridge bot commented Feb 26, 2026

Webrevs

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Feb 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approval Requires approval; will be removed when approval is received backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant