8374506: Incorrect positioning of arrow icon in parent JMenu in Windows L&F#311
8374506: Incorrect positioning of arrow icon in parent JMenu in Windows L&F#311rm-gh-8 wants to merge 1 commit intoopenjdk:masterfrom
Conversation
|
👋 Welcome back rm-gh-8! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
This backport pull request has now been updated with issue from the original commit. |
|
|
|
/approval request for backport of JDK-8374506: Incorrect positioning of arrow icon in parent JMenu in Windows L&F. This PR fixes the submenu arrow icon overlapping with long menu text in Windows L&F by adding a gap for the arrow icon rect, though reviewers note it's a stopgap solution and the underlying menu width calculation issue remains unaddressed. For parity with Oracle JDK. Low-Medium Risk - It's a Windows-only visual fix for a specific layout issue, but it's acknowledged as a temporary |
Backporting JDK-8374506: Incorrect positioning of arrow icon in parent JMenu in Windows L&F.
This PR fixes the submenu arrow icon overlapping with long menu text in Windows L&F by adding a gap for the arrow icon rect, though reviewers note it's a stopgap solution and the underlying menu width calculation issue remains unaddressed.
For parity with Oracle JDK.
Ran related tests on windows-x64:
../jtreg/build/images/jtreg/bin/jtreg -jdk build/windows-x86_64-server-fastdebug/images/jdk -m test/jdk/javax/swing/JMenuItem/LargeMenuTextArrowIconPosition.javaScreenshot:
Results:
Success
LargeMenuTextArrowIconPosition.jtr.log
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/311/head:pull/311$ git checkout pull/311Update a local copy of the PR:
$ git checkout pull/311$ git pull https://git.openjdk.org/jdk25u-dev.git pull/311/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 311View PR using the GUI difftool:
$ git pr show -t 311Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/311.diff
Using Webrev
Link to Webrev Comment