8377934: containers/docker/TestJcmd.java skipped GID xxx already exists#29724
Open
sendaoYan wants to merge 2 commits intoopenjdk:masterfrom
Open
8377934: containers/docker/TestJcmd.java skipped GID xxx already exists#29724sendaoYan wants to merge 2 commits intoopenjdk:masterfrom
sendaoYan wants to merge 2 commits intoopenjdk:masterfrom
Conversation
|
👋 Welcome back syan! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
@sendaoYan The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi all,
Test containers/docker/TestJcmd.java report skipped "groupadd: GID '998' already exists" because the group id has been occupy by some other group. This PR move the GID which get from
getent group %s | cut -d: -f1to new GID 9999, and then return true forcely to avoid return fail when there is no gruop occpy the expected GID. GID number larger that 1000 will be empty generally.Change has been verified locally. Test-fix only, no risk.
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/29724/head:pull/29724$ git checkout pull/29724Update a local copy of the PR:
$ git checkout pull/29724$ git pull https://git.openjdk.org/jdk.git pull/29724/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 29724View PR using the GUI difftool:
$ git pr show -t 29724Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/29724.diff
Using Webrev
Link to Webrev Comment